Patchwork [RESEND] MTD: maps/pxa2xx_flash: fix build breakage

login
register
mail settings
Submitter Mike Rapoport
Date March 31, 2009, 11:42 a.m.
Message ID <49D201BC.3050404@compulab.co.il>
Download mbox | patch
Permalink /patch/25385/
State New, archived
Headers show

Comments

Mike Rapoport - March 31, 2009, 11:42 a.m.
LD      init/built-in.o
  LD      .tmp_vmlinux1
`pxa2xx_flash_remove' referenced in section `.data' of
drivers/built-in.o: defined in discarded section `.exit.text' of
drivers/built-in.o
make: *** [.tmp_vmlinux1] Error 1

Signed-off-by: Mike Rapoport <mike@compulab.co.il>
---
 drivers/mtd/maps/pxa2xx-flash.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Russell King - ARM Linux - March 31, 2009, 6:45 p.m.
On Tue, Mar 31, 2009 at 02:42:52PM +0300, Mike Rapoport wrote:
>   LD      init/built-in.o
>   LD      .tmp_vmlinux1
> `pxa2xx_flash_remove' referenced in section `.data' of
> drivers/built-in.o: defined in discarded section `.exit.text' of
> drivers/built-in.o
> make: *** [.tmp_vmlinux1] Error 1

I've sent a whole raft of these to the cause of these several days ago
to lkml and the cause of this breakage... waiting for it to hit Linus'
tree.

Patch

diff --git a/drivers/mtd/maps/pxa2xx-flash.c b/drivers/mtd/maps/pxa2xx-flash.c
index e9026cb..572d32f 100644
--- a/drivers/mtd/maps/pxa2xx-flash.c
+++ b/drivers/mtd/maps/pxa2xx-flash.c
@@ -117,7 +117,7 @@  static int __init pxa2xx_flash_probe(struct platform_device *pdev)
 	return 0;
 }

-static int __exit pxa2xx_flash_remove(struct platform_device *dev)
+static int __devexit pxa2xx_flash_remove(struct platform_device *dev)
 {
 	struct pxa2xx_flash_info *info = platform_get_drvdata(dev);