Patchwork ahci: use ATA_BUSY

login
register
mail settings
Submitter Sergei Shtylyov
Date June 22, 2013, 9:14 p.m.
Message ID <201306230114.37999.sergei.shtylyov@cogentembedded.com>
Download mbox | patch
Permalink /patch/253442/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Sergei Shtylyov - June 22, 2013, 9:14 p.m.
ahci_p5wdh_hardreset() uses bare number for the BSY bit of the ATA status
register, despite it's #define'd in <linux/ata.h>.

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
 drivers/ata/ahci.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sergei Shtylyov - June 22, 2013, 9:16 p.m.
Hello.

On 06/23/2013 01:14 AM, Sergei Shtylyov wrote:

> ahci_p5wdh_hardreset() uses bare number for the BSY bit of the ATA status
> register, despite it's #define'd in <linux/ata.h>.

> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

> ---
The patch is against 'for-3.11' branch of the 'libata.git' repo.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

Index: libata/drivers/ata/ahci.c
===================================================================
--- libata.orig/drivers/ata/ahci.c
+++ libata/drivers/ata/ahci.c
@@ -583,7 +583,7 @@  static int ahci_p5wdh_hardreset(struct a
 
 	/* clear D2H reception area to properly wait for D2H FIS */
 	ata_tf_init(link->device, &tf);
-	tf.command = 0x80;
+	tf.command = ATA_BUSY;
 	ata_tf_to_fis(&tf, 0, 0, d2h_fis);
 
 	rc = sata_link_hardreset(link, sata_ehc_deb_timing(&link->eh_context),