Patchwork [PULL,10/17] qxl: Fix QXLRam initialisation.

login
register
mail settings
Submitter Michael Tokarev
Date June 22, 2013, 9:24 a.m.
Message ID <1371893076-9643-11-git-send-email-mjt@msgid.tls.msk.ru>
Download mbox | patch
Permalink /patch/253406/
State New
Headers show

Comments

Michael Tokarev - June 22, 2013, 9:24 a.m.
From: Anthony PERARD <anthony.perard@citrix.com>

The qxl driver expect NULL for QXLRam.memory_configs, but this is never
initialized.

If memory is set to 0xc2c2.., it leads to a spice-critical error when
trying to start qxl.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
 hw/display/qxl.c |    1 +
 1 file changed, 1 insertion(+)

Patch

diff --git a/hw/display/qxl.c b/hw/display/qxl.c
index c475cb1..937a402 100644
--- a/hw/display/qxl.c
+++ b/hw/display/qxl.c
@@ -387,6 +387,7 @@  static void init_qxl_ram(PCIQXLDevice *d)
     d->ram->int_pending = cpu_to_le32(0);
     d->ram->int_mask    = cpu_to_le32(0);
     d->ram->update_surface = 0;
+    d->ram->monitors_config = 0;
     SPICE_RING_INIT(&d->ram->cmd_ring);
     SPICE_RING_INIT(&d->ram->cursor_ring);
     SPICE_RING_INIT(&d->ram->release_ring);