Patchwork libunwind: new package

login
register
mail settings
Submitter ANDY KENNEDY
Date June 21, 2013, 11:03 p.m.
Message ID <F9C551623D2CBB4C9488801D14F864C639A6A708@ex-mb1.corp.adtran.com>
Download mbox | patch
Permalink /patch/253320/
State Superseded
Headers show

Comments

ANDY KENNEDY - June 21, 2013, 11:03 p.m.
Signed-off-by:  Andy Kennedy <andy.kennedy@adtran.com>
---
Thomas Petazzoni - June 22, 2013, 9:15 a.m.
Dear ANDY KENNEDY,

On Fri, 21 Jun 2013 23:03:10 +0000, ANDY KENNEDY wrote:

> +LIBUNWIND_VERSION = 1.1
> +LIBUNWIND_SITE = http://download.savannah.gnu.org/releases/libunwind
> +LIBUNWIND_INSTALL_STAGING = YES
> +LIBUNWIND_LICENSE_FILES = COPYING

Please also add a LIBUNWIND_LICENSE variable with the name of the
license.

Thanks,

Thomas
ANDY KENNEDY - June 24, 2013, 2:24 p.m.
Thomas:  To what shall I set the License variable?

I have NO IDEA what it should be.  This isn't GPL code, not
MIT, not BSD, nothing I've seen before.  All I know is that it
is free of any restrictions, though copyrighted by HP.

Andy

License text:

Copyright (c) 2002 Hewlett-Packard Co.

Permission is hereby granted, free of charge, to any person obtaining
a copy of this software and associated documentation files (the
"Software"), to deal in the Software without restriction, including
without limitation the rights to use, copy, modify, merge, publish,
distribute, sublicense, and/or sell copies of the Software, and to
permit persons to whom the Software is furnished to do so, subject to
the following conditions:

The above copyright notice and this permission notice shall be
included in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.



> -----Original Message-----
> From: Thomas Petazzoni [mailto:thomas.petazzoni@free-electrons.com]
> Sent: Saturday, June 22, 2013 4:15 AM
> To: ANDY KENNEDY
> Cc: buildroot@busybox.net
> Subject: Re: [Buildroot] [PATCH] libunwind: new package
> 
> Dear ANDY KENNEDY,
> 
> On Fri, 21 Jun 2013 23:03:10 +0000, ANDY KENNEDY wrote:
> 
> > +LIBUNWIND_VERSION = 1.1
> > +LIBUNWIND_SITE = http://download.savannah.gnu.org/releases/libunwind
> > +LIBUNWIND_INSTALL_STAGING = YES
> > +LIBUNWIND_LICENSE_FILES = COPYING
> 
> Please also add a LIBUNWIND_LICENSE variable with the name of the
> license.
> 
> Thanks,
> 
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com
Thomas Petazzoni - June 24, 2013, 2:29 p.m.
Hello,

On Mon, 24 Jun 2013 14:24:55 +0000, ANDY KENNEDY wrote:

> Thomas:  To what shall I set the License variable?
> 
> I have NO IDEA what it should be.  This isn't GPL code, not
> MIT, not BSD, nothing I've seen before.  All I know is that it
> is free of any restrictions, though copyrighted by HP.
> 
> Andy
> 
> License text:
> 
> Copyright (c) 2002 Hewlett-Packard Co.
> 
> Permission is hereby granted, free of charge, to any person obtaining
> a copy of this software and associated documentation files (the
> "Software"), to deal in the Software without restriction, including
> without limitation the rights to use, copy, modify, merge, publish,
> distribute, sublicense, and/or sell copies of the Software, and to
> permit persons to whom the Software is furnished to do so, subject to
> the following conditions:
> 
> The above copyright notice and this permission notice shall be
> included in all copies or substantial portions of the Software.
> 
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
> LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
> OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
> WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

Seeing this, I would probably do something like:

LIBUNWIND_LICENSE = libunwind license (BSD-like)

or something like that.

Thomas
Arnout Vandecappelle - June 24, 2013, 4:56 p.m.
On 24/06/13 16:24, ANDY KENNEDY wrote:
> I have NO IDEA what it should be.  This isn't GPL code, not
> MIT, not BSD, nothing I've seen before.  All I know is that it
> is free of any restrictions, though copyrighted by HP.
>
> Andy
>
> License text:
>
> Copyright (c) 2002 Hewlett-Packard Co.
>
> Permission is hereby granted, free of charge, to any person obtaining
> a copy of this software and associated documentation files (the
> "Software"), to deal in the Software without restriction, including
> without limitation the rights to use, copy, modify, merge, publish,
> distribute, sublicense, and/or sell copies of the Software, and to
> permit persons to whom the Software is furnished to do so, subject to
> the following conditions:
>
> The above copyright notice and this permission notice shall be
> included in all copies or substantial portions of the Software.
>
> THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
> LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
> OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
> WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

  How exactly does this text differ from MIT?

  Regards,
  Arnout
ANDY KENNEDY - June 25, 2013, 5:53 p.m.
>   How exactly does this text differ from MIT?
> 
>   Regards,
>   Arnout
> 

Listen here Arnout, don't try to confuse this issue with FACTS.

Shall I change it? ;)

I was only working from memory.  I clearly haven't read the MIT
license text in a while.

Andy
Arnout Vandecappelle - June 25, 2013, 9:08 p.m.
On 25/06/13 19:53, ANDY KENNEDY wrote:
>>    How exactly does this text differ from MIT?
>>
>>    Regards,
>>    Arnout
>>
>
> Listen here Arnout, don't try to confuse this issue with FACTS.
>
> Shall I change it? ;)
>
> I was only working from memory.  I clearly haven't read the MIT
> license text in a while.

  I haven't actually verified whether it is MIT, it just looks like MIT 
to me at a casual glance. So my question was a honest question.

  Regards,
  Arnout
ANDY KENNEDY - June 25, 2013, 9:38 p.m.
> > Listen here Arnout, don't try to confuse this issue with FACTS.
> >
> > Shall I change it? ;)
> >
> > I was only working from memory.  I clearly haven't read the MIT
> > license text in a while.
> 
>   I haven't actually verified whether it is MIT, it just looks like MIT
> to me at a casual glance. So my question was a honest question.

I did.  You were COMPLETELY correct, hence my reply.

So, you didn't answer the question:  Shall I change it?

>   Regards,
>   Arnout

Patch

diff -Naur a/package/Config.in b/package/Config.in
--- a/package/Config.in 2013-06-20 10:32:07.000000000 -0500
+++ b/package/Config.in 2013-06-21 17:00:21.000000000 -0500
@@ -612,6 +612,7 @@ 
 source "package/libtasn1/Config.in"
 source "package/libtpl/Config.in"
 source "package/libseccomp/Config.in"
+source "package/libunwind/Config.in"
 source "package/liburcu/Config.in"
 source "package/linux-pam/Config.in"
 source "package/log4cxx/Config.in"
diff -Naur a/package/libunwind/Config.in b/package/libunwind/Config.in
--- a/package/libunwind/Config.in       1969-12-31 18:00:00.000000000 -0600
+++ b/package/libunwind/Config.in       2013-06-21 17:23:46.000000000 -0500
@@ -0,0 +1,6 @@ 
+config BR2_PACKAGE_LIBUNWIND
+	bool "libunwind"
+	help
+	  C API to determine the call-chain of a program.
+
+	  Project home:  <http://www.nongnu.org/libunwind/index.html>
diff -Naur a/package/libunwind/libunwind.mk b/package/libunwind/libunwind.mk
--- a/package/libunwind/libunwind.mk    1969-12-31 18:00:00.000000000 -0600
+++ b/package/libunwind/libunwind.mk    2013-06-21 17:23:38.000000000 -0500
@@ -0,0 +1,12 @@ 
+################################################################################
+#
+# libuwind
+#
+################################################################################
+
+LIBUNWIND_VERSION = 1.1
+LIBUNWIND_SITE = http://download.savannah.gnu.org/releases/libunwind
+LIBUNWIND_INSTALL_STAGING = YES
+LIBUNWIND_LICENSE_FILES = COPYING
+
+$(eval $(autotools-package))