Patchwork [v2,3/3] qapi-schema: Use BlockdevSnapshot type for blockdev-snapshot-sync

login
register
mail settings
Submitter Kevin Wolf
Date June 21, 2013, 3:46 p.m.
Message ID <1371829589-18045-4-git-send-email-kwolf@redhat.com>
Download mbox | patch
Permalink /patch/253258/
State New
Headers show

Comments

Kevin Wolf - June 21, 2013, 3:46 p.m.
We don't have to duplicate the definition any more now that we may refer
to a type instead.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 qapi-schema.json | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)

Patch

diff --git a/qapi-schema.json b/qapi-schema.json
index a80ee40..54fbeef 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -1652,16 +1652,7 @@ 
 #
 # Generates a synchronous snapshot of a block device.
 #
-# @device:  the name of the device to generate the snapshot from.
-#
-# @snapshot-file: the target of the new image. If the file exists, or if it
-#                 is a device, the snapshot will be created in the existing
-#                 file/device. If does not exist, a new file will be created.
-#
-# @format: #optional the format of the snapshot image, default is 'qcow2'.
-#
-# @mode: #optional whether and how QEMU should create a new image, default is
-#        'absolute-paths'.
+# For the arguments, see the documentation of BlockdevSnapshot.
 #
 # Returns: nothing on success
 #          If @device is not a valid block device, DeviceNotFound
@@ -1669,8 +1660,7 @@ 
 # Since 0.14.0
 ##
 { 'command': 'blockdev-snapshot-sync',
-  'data': { 'device': 'str', 'snapshot-file': 'str', '*format': 'str',
-            '*mode': 'NewImageMode'} }
+  'data': 'BlockdevSnapshot' }
 
 ##
 # @human-monitor-command: