Patchwork [09/13] qemu-char: use ChardevBackendKind in in CharDriver

login
register
mail settings
Submitter Gerd Hoffmann
Date June 21, 2013, 10:38 a.m.
Message ID <1371811105-730-10-git-send-email-kraxel@redhat.com>
Download mbox | patch
Permalink /patch/253194/
State New
Headers show

Comments

Gerd Hoffmann - June 21, 2013, 10:38 a.m.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 qemu-char.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Michael Tokarev - June 21, 2013, 6:36 p.m.
21.06.2013 14:38, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  qemu-char.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/qemu-char.c b/qemu-char.c
> index 5751391..1c0903f 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -3127,7 +3127,7 @@ typedef struct CharDriver {
>      /* old, pre qapi */
>      CharDriverState *(*open)(QemuOpts *opts);
>      /* new, qapi-based */
> -    int kind;
> +    ChardevBackendKind kind;
>      void (*parse)(QemuOpts *opts, ChardevBackend *backend, Error **errp);
>  } CharDriver;

How about switching argument of register_char_driver_qapi() to the same
type as well?

Thanks,

/mjt

Patch

diff --git a/qemu-char.c b/qemu-char.c
index 5751391..1c0903f 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -3127,7 +3127,7 @@  typedef struct CharDriver {
     /* old, pre qapi */
     CharDriverState *(*open)(QemuOpts *opts);
     /* new, qapi-based */
-    int kind;
+    ChardevBackendKind kind;
     void (*parse)(QemuOpts *opts, ChardevBackend *backend, Error **errp);
 } CharDriver;