Patchwork [1/2] kernel: remove unnecessary head file

login
register
mail settings
Submitter junwei.zhang@6wind.com
Date June 21, 2013, 2:19 a.m.
Message ID <1371781157-16743-1-git-send-email-junwei.zhang@6wind.com>
Download mbox | patch
Permalink /patch/253119/
State Changes Requested
Delegated to: David Miller
Headers show

Comments

junwei.zhang@6wind.com - June 21, 2013, 2:19 a.m.
From: JunweiZhang <junwei.zhang@6wind.com>

ip_vs.h is not necessary for sysctl_binary.c.

prepare for the next patch to avoid compile issue.

Signed-off-by: JunweiZhang <junwei.zhang@6wind.com>
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
---
 kernel/sysctl_binary.c | 1 -
 1 file changed, 1 deletion(-)
Julian Anastasov - June 21, 2013, 6:40 a.m.
Hello,

On Fri, 21 Jun 2013, junwei.zhang@6wind.com wrote:

> From: JunweiZhang <junwei.zhang@6wind.com>
> 
> ip_vs.h is not necessary for sysctl_binary.c.
> 
> prepare for the next patch to avoid compile issue.
> 
> Signed-off-by: JunweiZhang <junwei.zhang@6wind.com>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>

	Both patches look good to me:

Reviewed-by: Julian Anastasov <ja@ssi.bg>

	Please use version descriptor in future, for example:

[PATCHv2 ...] ...

> ---
>  kernel/sysctl_binary.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/sysctl_binary.c b/kernel/sysctl_binary.c
> index aea4a9e..b609213 100644
> --- a/kernel/sysctl_binary.c
> +++ b/kernel/sysctl_binary.c
> @@ -3,7 +3,6 @@
>  #include "../fs/xfs/xfs_sysctl.h"
>  #include <linux/sunrpc/debug.h>
>  #include <linux/string.h>
> -#include <net/ip_vs.h>
>  #include <linux/syscalls.h>
>  #include <linux/namei.h>
>  #include <linux/mount.h>
> -- 
> 1.8.1.2

Regards

--
Julian Anastasov <ja@ssi.bg>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - June 24, 2013, 7:23 a.m.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - June 24, 2013, 7:24 a.m.
These two patches do not apply to net-next.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Simon Horman - June 26, 2013, 8:58 a.m.
On Mon, Jun 24, 2013 at 12:24:01AM -0700, David Miller wrote:
> 
> These two patches do not apply to net-next.

The reposted versions seem to apply to ipvs-next.
I'll take them through there.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/kernel/sysctl_binary.c b/kernel/sysctl_binary.c
index aea4a9e..b609213 100644
--- a/kernel/sysctl_binary.c
+++ b/kernel/sysctl_binary.c
@@ -3,7 +3,6 @@ 
 #include "../fs/xfs/xfs_sysctl.h"
 #include <linux/sunrpc/debug.h>
 #include <linux/string.h>
-#include <net/ip_vs.h>
 #include <linux/syscalls.h>
 #include <linux/namei.h>
 #include <linux/mount.h>