From patchwork Thu Jun 20 15:53:27 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Genoud X-Patchwork-Id: 253017 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from hemlock.osuosl.org (hemlock.osuosl.org [140.211.166.133]) by ozlabs.org (Postfix) with ESMTP id 70BD92C0209 for ; Fri, 21 Jun 2013 01:54:02 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 9AE6FA0239; Thu, 20 Jun 2013 15:53:57 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JMUTbt4-Gc-p; Thu, 20 Jun 2013 15:53:49 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 5CF83A025F; Thu, 20 Jun 2013 15:53:49 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id BE1D28F79E for ; Thu, 20 Jun 2013 15:53:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 9EE3D8D01F for ; Thu, 20 Jun 2013 15:53:51 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iAJKyKLdrACu for ; Thu, 20 Jun 2013 15:53:50 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45]) by whitealder.osuosl.org (Postfix) with ESMTPS id 1BD608D006 for ; Thu, 20 Jun 2013 15:53:49 +0000 (UTC) Received: by mail-wg0-f45.google.com with SMTP id j13so5634726wgh.0 for ; Thu, 20 Jun 2013 08:53:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=aBx0nucDyqwdeqUES8TUcGzHNq1Npllm+0mi3vpn+Kk=; b=FgOKXVEWZDUhClv7tlSQs/W3W+jnLrDWjfPKKJgFCb8rVaT6DndK8YRIYmdjsnsQVR iTzY4dRGnFuL4jjcUMbuAGJdR46IABv+I9xO+KihyAdKNh1dsBojcdYk056ha8u5cjrn BsTcWve9W5ryI9mNhXQZrl0UPd4u8nPG3o0OqqxbYiLpnRXJ79Q89vr3OhVn2nt7I6ly 2liukvLdrlsMIaZO/SXvik6XmZTeCp3Hesk+OfUmBdRRtbTFtY2FH5i1e0PB70TABRne RoXTFo6I0yyqLq+7Ou1/yzagEK2bARpSaGYS4u4ri6M668dt4qv0EnJNp5QfM3a/y/c5 lWjw== X-Received: by 10.194.20.97 with SMTP id m1mr6214181wje.31.1371743628514; Thu, 20 Jun 2013 08:53:48 -0700 (PDT) Received: from lnx-rg.pr (lyon.paratronic.fr. [213.41.177.106]) by mx.google.com with ESMTPSA id o14sm17082109wiv.3.2013.06.20.08.53.46 for (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 20 Jun 2013 08:53:47 -0700 (PDT) From: Richard Genoud To: buildroot@busybox.net Date: Thu, 20 Jun 2013 17:53:27 +0200 Message-Id: <1371743610-17810-2-git-send-email-richard.genoud@gmail.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1371743610-17810-1-git-send-email-richard.genoud@gmail.com> References: <1371743610-17810-1-git-send-email-richard.genoud@gmail.com> Subject: [Buildroot] [PATCH 1/4] TCL: change BR2_PACKAGE_TCL_SHLIB_ONLY option X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net It's not convenient to have an option (defaulted to yes) that removes a software. For instance, usb_modeswitching_data needs the tclsh interpreter, so it would have to un-select this option, but select TCL. Having an option that adds the tclsh binary (defaulted to no to keep the same behaviour) is way more convenient. Moreover, it seems that it was intended liked that at the begining because usb_modeswitching_data already selects BR2_PACKAGE_TCL_TCLSH which wasn't declared anywhere Signed-off-by: Richard Genoud --- package/tcl/Config.in | 11 +++++------ package/tcl/tcl.mk | 2 +- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/package/tcl/Config.in b/package/tcl/Config.in index 7a4d887..8af7980 100644 --- a/package/tcl/Config.in +++ b/package/tcl/Config.in @@ -16,12 +16,11 @@ config BR2_PACKAGE_TCL_DEL_ENCODINGS It saves approx. 1.4 Mb of space. -config BR2_PACKAGE_TCL_SHLIB_ONLY - bool "install only shared library" - default y +config BR2_PACKAGE_TCL_TCLSH + bool "Install also tclsh binary, not only the shared library" + default n depends on BR2_PACKAGE_TCL help - Install only TCL shared library and not binary tcl - interpreter(tclsh8.4). + Install the TCL interpreter binary file(tclsh8.4). - Saves ~14kb. + Adds ~14kb. diff --git a/package/tcl/tcl.mk b/package/tcl/tcl.mk index 144fefe..1c23420 100644 --- a/package/tcl/tcl.mk +++ b/package/tcl/tcl.mk @@ -26,7 +26,7 @@ define TCL_POST_INSTALL_CLEANUP -if [ "$(BR2_PACKAGE_TCL_DEL_ENCODINGS)" = "y" ]; then \ rm -Rf $(TARGET_DIR)/usr/lib/tcl$(TCL_VERSION_MAJOR)/encoding/*; \ fi - -if [ "$(BR2_PACKAGE_TCL_SHLIB_ONLY)" = "y" ]; then \ + -if [ "$(BR2_PACKAGE_TCL_TCLSH)" != "y" ]; then \ rm -f $(TARGET_DIR)/usr/bin/tclsh$(TCL_VERSION_MAJOR); \ fi endef