From patchwork Mon Mar 30 09:03:01 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jesper Dangaard Brouer X-Patchwork-Id: 25300 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 1AE1FDDE22 for ; Mon, 30 Mar 2009 20:04:08 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758081AbZC3JDF (ORCPT ); Mon, 30 Mar 2009 05:03:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757359AbZC3JDF (ORCPT ); Mon, 30 Mar 2009 05:03:05 -0400 Received: from lanfw001a.cxnet.dk ([87.72.215.196]:40332 "EHLO lanfw001a.cxnet.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758081AbZC3JDD (ORCPT ); Mon, 30 Mar 2009 05:03:03 -0400 Received: from localhost.localdomain (unknown [172.31.4.93]) by lanfw001a.cxnet.dk (Postfix) with ESMTP id 648DB163626; Mon, 30 Mar 2009 11:03:01 +0200 (CEST) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by localhost.localdomain (Postfix) with ESMTP id 589B0CBA36; Mon, 30 Mar 2009 11:03:01 +0200 (CEST) From: Jesper Dangaard Brouer Subject: [PATCH 2/3] Doc: Fix wrong API example usage of call_rcu(). To: "David S. Miller" Cc: "Paul E. McKenney" , netdev@vger.kernel.org Date: Mon, 30 Mar 2009 11:03:01 +0200 Message-ID: <20090330090301.19172.42721.stgit@localhost.localdomain> In-Reply-To: <20090330085302.19172.22808.stgit@localhost.localdomain> References: <20090330085302.19172.22808.stgit@localhost.localdomain> User-Agent: StGIT/0.14.3 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org At some point the API of call_rcu() changed from three parameters to two parameters, correct the documentation. One confusing thing in RCU/listRCU.txt, which is NOT fixed in this patch, is that no reason or explaination is given for using call_rcu() instead of the normal synchronize_rcu() call. Reviewed-by: Paul E. McKenney Signed-off-by: Jesper Dangaard Brouer --- Documentation/RCU/listRCU.txt | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/Documentation/RCU/listRCU.txt b/Documentation/RCU/listRCU.txt index 1fd1753..4349c14 100644 --- a/Documentation/RCU/listRCU.txt +++ b/Documentation/RCU/listRCU.txt @@ -118,7 +118,7 @@ Following are the RCU equivalents for these two functions: list_for_each_entry(e, list, list) { if (!audit_compare_rule(rule, &e->rule)) { list_del_rcu(&e->list); - call_rcu(&e->rcu, audit_free_rule, e); + call_rcu(&e->rcu, audit_free_rule); return 0; } } @@ -206,7 +206,7 @@ RCU ("read-copy update") its name. The RCU code is as follows: ne->rule.action = newaction; ne->rule.file_count = newfield_count; list_replace_rcu(e, ne); - call_rcu(&e->rcu, audit_free_rule, e); + call_rcu(&e->rcu, audit_free_rule); return 0; } } @@ -283,7 +283,7 @@ flag under the spinlock as follows: list_del_rcu(&e->list); e->deleted = 1; spin_unlock(&e->lock); - call_rcu(&e->rcu, audit_free_rule, e); + call_rcu(&e->rcu, audit_free_rule); return 0; } }