Patchwork [net-next] ipv6: remove a useless pr_info() in addrconf_gre_config()

login
register
mail settings
Submitter Amerigo Wang
Date June 20, 2013, 8:30 a.m.
Message ID <1371717000-22295-1-git-send-email-amwang@redhat.com>
Download mbox | patch
Permalink /patch/252799/
State Accepted
Delegated to: David Miller
Headers show

Comments

Amerigo Wang - June 20, 2013, 8:30 a.m.
From: Cong Wang <amwang@redhat.com>

This is debug info, should at least be pr_debug(), but given
that this code is in upstream for two years, there is no
need to keep this debugging printk any more, so just remove it.

Cc: Stephen Hemminger <stephen@networkplumber.org>
Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Cong Wang <amwang@redhat.com>

---
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - June 24, 2013, 1:47 a.m.
From: Cong Wang <amwang@redhat.com>
Date: Thu, 20 Jun 2013 16:30:00 +0800

> From: Cong Wang <amwang@redhat.com>
> 
> This is debug info, should at least be pr_debug(), but given
> that this code is in upstream for two years, there is no
> need to keep this debugging printk any more, so just remove it.
> 
> Cc: Stephen Hemminger <stephen@networkplumber.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Signed-off-by: Cong Wang <amwang@redhat.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 8044912..90788a1 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -2760,8 +2760,6 @@  static void addrconf_gre_config(struct net_device *dev)
 	struct inet6_dev *idev;
 	struct in6_addr addr;
 
-	pr_info("%s(%s)\n", __func__, dev->name);
-
 	ASSERT_RTNL();
 
 	if ((idev = ipv6_find_idev(dev)) == NULL) {