From patchwork Thu Jun 20 06:55:28 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Armbruster X-Patchwork-Id: 252757 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A75C12C02B6 for ; Thu, 20 Jun 2013 16:56:03 +1000 (EST) Received: from localhost ([::1]:37710 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpYmn-0007As-KB for incoming@patchwork.ozlabs.org; Thu, 20 Jun 2013 02:56:01 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60321) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpYmP-00079d-8r for qemu-devel@nongnu.org; Thu, 20 Jun 2013 02:55:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UpYmL-0004Za-QJ for qemu-devel@nongnu.org; Thu, 20 Jun 2013 02:55:37 -0400 Received: from oxygen.pond.sub.org ([2a01:4f8:121:10e4::3]:38840) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpYmL-0004YA-Dg for qemu-devel@nongnu.org; Thu, 20 Jun 2013 02:55:33 -0400 Received: from blackfin.pond.sub.org (p5B32AC8A.dip0.t-ipconnect.de [91.50.172.138]) by oxygen.pond.sub.org (Postfix) with ESMTPA id E59E3A5C62; Thu, 20 Jun 2013 08:55:30 +0200 (CEST) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 0BF66200B3; Thu, 20 Jun 2013 08:55:30 +0200 (CEST) From: Markus Armbruster To: qemu-devel@nongnu.org Date: Thu, 20 Jun 2013 08:55:28 +0200 Message-Id: <1371711329-9144-2-git-send-email-armbru@redhat.com> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1371711329-9144-1-git-send-email-armbru@redhat.com> References: <1371711329-9144-1-git-send-email-armbru@redhat.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a01:4f8:121:10e4::3 Cc: aliguori@us.ibm.com, afaerber@suse.de Subject: [Qemu-devel] [PATCH v2 1/2] libqtest: Plug fd and memory leaks in qtest_quit() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Reviewed-by: Anthony Liguori Signed-off-by: Markus Armbruster --- tests/libqtest.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/libqtest.c b/tests/libqtest.c index 879ffe9..bb82069 100644 --- a/tests/libqtest.c +++ b/tests/libqtest.c @@ -171,12 +171,16 @@ void qtest_quit(QTestState *s) waitpid(pid, &status, 0); } + close(s->fd); + close(s->qmp_fd); + g_string_free(s->rx, true); unlink(s->pid_file); unlink(s->socket_path); unlink(s->qmp_socket_path); g_free(s->pid_file); g_free(s->socket_path); g_free(s->qmp_socket_path); + g_free(s); } static void socket_sendf(int fd, const char *fmt, va_list ap)