From patchwork Thu Jun 20 05:44:56 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: jon ernst X-Patchwork-Id: 252753 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id E76882C029D for ; Thu, 20 Jun 2013 15:44:58 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751833Ab3FTFo6 (ORCPT ); Thu, 20 Jun 2013 01:44:58 -0400 Received: from mout.gmx.net ([74.208.4.201]:62971 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751265Ab3FTFo5 (ORCPT ); Thu, 20 Jun 2013 01:44:57 -0400 Received: from mailout-us.gmx.com ([172.19.198.48]) by mrigmx.server.lan (mrigmxus002) with ESMTP (Nemesis) id 0M9HDu-1V180F17L4-00CfwS for ; Thu, 20 Jun 2013 07:44:57 +0200 Received: (qmail 22555 invoked by uid 0); 20 Jun 2013 05:44:57 -0000 Received: from 72.219.205.124 by rms-us024 with HTTP Date: Thu, 20 Jun 2013 01:44:56 -0400 From: "jon ernst" Message-ID: <20130620054456.271300@gmx.com> MIME-Version: 1.0 Subject: [PATCH] ext4: deleted unnecessary assignments and useless "if" statement To: linux-ext4@vger.kernel.org X-Flags: 0001 X-Mailer: GMX.com Web Mailer x-registered: 0 X-GMX-UID: j/OwcZ4I3zOlOKCRun0hTGF+IGRvb4As Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org comparing unsigned variable with 0 always return false. err = 0 is duplicated and unnecessary. Signed-off-by: "Jon Ernst" --- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/fs/ext4/inode.c     +++ b/fs/ext4/inode.c     @@ -1098,8 +1098,6 @@ static int ext4_write_end(struct file *f        if (i_size_changed)                ext4_mark_inode_dirty(handle, inode); -       if (copied < 0) -               ret = copied;        if (pos + len > inode->i_size && ext4_can_truncate(inode))                /* if we have allocated more blocks and copied                 * less. We will have blocks allocated outside @@ -3365,7 +3363,6 @@ int ext4_block_zero_page_range(handle_t                pos += blocksize;        } -       err = 0;        if (buffer_freed(bh)) {                BUFFER_TRACE(bh, "freed: skip");                goto unlock; @@ -3405,7 +3402,6 @@ int ext4_block_zero_page_range(handle_t        BUFFER_TRACE(bh, "zeroed end of block"); -       err = 0;        if (ext4_should_journal_data(inode)) {                err = ext4_handle_dirty_metadata(handle, inode, bh);        } else {