Patchwork [U-Boot] Fix for incorrect conversion hex string to number (FMAN firmware address).

login
register
mail settings
Submitter Николай Пузанов
Date June 19, 2013, 7:48 a.m.
Message ID <CAKj6i9jcy_HVJPaMNBKq5-PLXA3CUMwcs4OpFBUGMz_MhYxp2w@mail.gmail.com>
Download mbox | patch
Permalink /patch/252689/
State Accepted
Delegated to: York Sun
Headers show

Comments

Николай Пузанов - June 19, 2013, 7:48 a.m.
---
 arch/powerpc/cpu/mpc85xx/fdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
1.8.1.2
York Sun - Aug. 9, 2013, 12:30 a.m.
On 06/19/2013 12:48 AM, Николай Пузанов wrote:
> ---
>  arch/powerpc/cpu/mpc85xx/fdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> ---
> 1.8.1.2
> 
> diff --git a/arch/powerpc/cpu/mpc85xx/fdt.c b/arch/powerpc/cpu/mpc85xx/fdt.c
> index 24eb978..ece1336 100644
> --- a/arch/powerpc/cpu/mpc85xx/fdt.c
> +++ b/arch/powerpc/cpu/mpc85xx/fdt.c
> @@ -492,7 +492,7 @@ void fdt_fixup_fman_firmware(void *blob)
>   if (!p)
>   return;
> 
> - fmanfw = (struct qe_firmware *) simple_strtoul(p, NULL, 0);
> + fmanfw = (struct qe_firmware *) simple_strtoul(p, NULL, 16);
>   if (!fmanfw)
>   return;
> 

Andy,

I want to close on this patch. Is there any reason we shouldn't apply
this patch? Why don't we have a problem without it?

York
York Sun - Aug. 20, 2013, 7:46 p.m.
On 08/08/2013 05:30 PM, York Sun wrote:
> On 06/19/2013 12:48 AM, Николай Пузанов wrote:
>> ---
>>  arch/powerpc/cpu/mpc85xx/fdt.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> ---
>> 1.8.1.2
>>
>> diff --git a/arch/powerpc/cpu/mpc85xx/fdt.c b/arch/powerpc/cpu/mpc85xx/fdt.c
>> index 24eb978..ece1336 100644
>> --- a/arch/powerpc/cpu/mpc85xx/fdt.c
>> +++ b/arch/powerpc/cpu/mpc85xx/fdt.c
>> @@ -492,7 +492,7 @@ void fdt_fixup_fman_firmware(void *blob)
>>   if (!p)
>>   return;
>>
>> - fmanfw = (struct qe_firmware *) simple_strtoul(p, NULL, 0);
>> + fmanfw = (struct qe_firmware *) simple_strtoul(p, NULL, 16);
>>   if (!fmanfw)
>>   return;
>>

Applied to u-boot-mpc85xx/master, added sign-off-by line.

York

Patch

diff --git a/arch/powerpc/cpu/mpc85xx/fdt.c b/arch/powerpc/cpu/mpc85xx/fdt.c
index 24eb978..ece1336 100644
--- a/arch/powerpc/cpu/mpc85xx/fdt.c
+++ b/arch/powerpc/cpu/mpc85xx/fdt.c
@@ -492,7 +492,7 @@  void fdt_fixup_fman_firmware(void *blob)
  if (!p)
  return;

- fmanfw = (struct qe_firmware *) simple_strtoul(p, NULL, 0);
+ fmanfw = (struct qe_firmware *) simple_strtoul(p, NULL, 16);
  if (!fmanfw)
  return;