From patchwork Wed Jun 19 20:40:35 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anthony Liguori X-Patchwork-Id: 252659 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id B17052C00A0 for ; Thu, 20 Jun 2013 06:46:06 +1000 (EST) Received: from localhost ([::1]:55635 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpPGW-0006S5-KI for incoming@patchwork.ozlabs.org; Wed, 19 Jun 2013 16:46:04 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33556) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpPCA-0000dO-Pz for qemu-devel@nongnu.org; Wed, 19 Jun 2013 16:41:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UpPC9-0004qx-AZ for qemu-devel@nongnu.org; Wed, 19 Jun 2013 16:41:34 -0400 Received: from e31.co.us.ibm.com ([32.97.110.149]:57928) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UpPC9-0004qi-1P for qemu-devel@nongnu.org; Wed, 19 Jun 2013 16:41:33 -0400 Received: from /spool/local by e31.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 19 Jun 2013 14:41:32 -0600 Received: from d03dlp01.boulder.ibm.com (9.17.202.177) by e31.co.us.ibm.com (192.168.1.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 19 Jun 2013 14:41:30 -0600 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id A7FDE1FF001D; Wed, 19 Jun 2013 14:36:15 -0600 (MDT) Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r5JKfSwg297742; Wed, 19 Jun 2013 14:41:28 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r5JKfRHx025629; Wed, 19 Jun 2013 14:41:27 -0600 Received: from titi.austin.rr.com ([9.49.221.0]) by d03av03.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id r5JKeaBk020317; Wed, 19 Jun 2013 14:41:23 -0600 From: Anthony Liguori To: qemu-devel@nongnu.org Date: Wed, 19 Jun 2013 15:40:35 -0500 Message-Id: <1371674435-14973-13-git-send-email-aliguori@us.ibm.com> X-Mailer: git-send-email 1.8.0 In-Reply-To: <1371674435-14973-1-git-send-email-aliguori@us.ibm.com> References: <1371674435-14973-1-git-send-email-aliguori@us.ibm.com> X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13061920-7282-0000-0000-00001879B8EB X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 32.97.110.149 Cc: Anthony Liguori , Alexey Kardashevskiy , Alex Graf , qemu-ppc@nongnu.org, Paul Mackerras , Andreas Faerber Subject: [Qemu-devel] [PATCH 12/12] spapr-vty: remove unfixable FIXME X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Anthony Liguori --- hw/char/spapr_vty.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/char/spapr_vty.c b/hw/char/spapr_vty.c index aa56f10..6834fe2 100644 --- a/hw/char/spapr_vty.c +++ b/hw/char/spapr_vty.c @@ -65,7 +65,13 @@ static int spapr_vty_getchars(VIOsPAPRVTYDevice *dev, uint8_t *buf, int max) static void spapr_vty_putchars(VIOsPAPRVTYDevice *dev, const uint8_t *buf, int len) { - /* FIXME: should check the qemu_chr_fe_write() return value */ + /* There is no flow control with this interface so we can't really + * do anything if we are unable to write out data. So we ignore errors + * here and silently drop the data. + * + * Our only option would be buffering but the kernel already has a buffer + * so that would only delay the inevitable. + */ qemu_chr_fe_write(dev->chardev, buf, len); }