Patchwork [12/12] spapr-vty: remove unfixable FIXME

login
register
mail settings
Submitter Anthony Liguori
Date June 19, 2013, 8:40 p.m.
Message ID <1371674435-14973-13-git-send-email-aliguori@us.ibm.com>
Download mbox | patch
Permalink /patch/252659/
State New
Headers show

Comments

Anthony Liguori - June 19, 2013, 8:40 p.m.
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
---
 hw/char/spapr_vty.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

Patch

diff --git a/hw/char/spapr_vty.c b/hw/char/spapr_vty.c
index aa56f10..6834fe2 100644
--- a/hw/char/spapr_vty.c
+++ b/hw/char/spapr_vty.c
@@ -65,7 +65,13 @@  static int spapr_vty_getchars(VIOsPAPRVTYDevice *dev, uint8_t *buf, int max)
 static void spapr_vty_putchars(VIOsPAPRVTYDevice *dev,
                                const uint8_t *buf, int len)
 {
-    /* FIXME: should check the qemu_chr_fe_write() return value */
+    /* There is no flow control with this interface so we can't really
+     * do anything if we are unable to write out data.  So we ignore errors
+     * here and silently drop the data.
+     *
+     * Our only option would be buffering but the kernel already has a buffer
+     * so that would only delay the inevitable.
+     */
     qemu_chr_fe_write(dev->chardev, buf, len);
 }