From patchwork Wed Jun 19 09:24:50 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tzu-Jung Lee X-Patchwork-Id: 252525 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ozlabs.org (Postfix) with ESMTP id 2FED92C0394 for ; Wed, 19 Jun 2013 19:22:02 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 967188CA39; Wed, 19 Jun 2013 09:22:00 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yyFfIvPcT4vO; Wed, 19 Jun 2013 09:21:59 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 4DAE18C615; Wed, 19 Jun 2013 09:21:58 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 9BEB38F753 for ; Wed, 19 Jun 2013 09:22:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id BB0FE8BF9C for ; Wed, 19 Jun 2013 09:21:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jUyJdt+R2slZ for ; Wed, 19 Jun 2013 09:21:55 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) by whitealder.osuosl.org (Postfix) with ESMTPS id D88848BE60 for ; Wed, 19 Jun 2013 09:21:55 +0000 (UTC) Received: by mail-pb0-f54.google.com with SMTP id ro2so4862602pbb.27 for ; Wed, 19 Jun 2013 02:21:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=qQ/PyoFsBTyLtuUGUaQ80rMcNZtlRO3qGMub6rRCbQI=; b=dJQsxv0TLXTfELLp9WB8J8VCg2snHzFWP1ug7/Pj8gcx2rMG1RKj3x6AVLUb1A4mMV LduN+y0Z8Xc4fYcqYKXvpr2wM8e6jRTXBpvhx1alCb7O4CP1QN7HAc3mVRZFb0rfL4nT LqOHgjLG/xA39R8nC7uUV4E+D6DaQiaK4gjY1xfsHlb4CSc7Sp76snUtK3tRTbM03Bah c6OwzRpDNYQu3VxiHcO0imL3hCkq6VCXY9XSRDoUScuBiuyKisMjJgvNlWA/ocxy3zC2 jA6f6DXR992WTw7bC8h2jx2+tR99lryMmrLAM/mnFaYlYck3pbhy+8lhy+FSpqbVr2oD baUg== X-Received: by 10.68.106.196 with SMTP id gw4mr1900567pbb.126.1371633715527; Wed, 19 Jun 2013 02:21:55 -0700 (PDT) Received: from localhost.localdomain (59-104-36-155.adsl.dynamic.seed.net.tw. [59.104.36.155]) by mx.google.com with ESMTPSA id iq6sm22399367pbc.1.2013.06.19.02.21.53 for (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 19 Jun 2013 02:21:54 -0700 (PDT) From: Tzu-Jung Lee To: buildroot@busybox.net Date: Wed, 19 Jun 2013 17:24:50 +0800 Message-Id: <1371633890-21646-1-git-send-email-tjlee@ambarella.com> X-Mailer: git-send-email 1.8.2.1 Cc: Tzu-Jung Lee Subject: [Buildroot] [PATCH] build: use find -perm /mode, instead of -perm +mode STRIP_FIND_CMD X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net The -perm +mode is deprecated, and sometimes yields suprising results. It can be confused with permission in symbolic mode, for example '+u+g', as POSIX spec suggests. Signed-off-by: Tzu-Jung Lee --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index c514e4f..d4be0d8 100644 --- a/Makefile +++ b/Makefile @@ -444,7 +444,7 @@ STRIP_FIND_CMD = find $(TARGET_DIR) ifneq (,$(call qstrip,$(BR2_STRIP_EXCLUDE_DIRS))) STRIP_FIND_CMD += \( $(call finddirclauses,$(TARGET_DIR),$(call qstrip,$(BR2_STRIP_EXCLUDE_DIRS))) \) -prune -o endif -STRIP_FIND_CMD += -type f -perm +111 +STRIP_FIND_CMD += -type f -perm /111 STRIP_FIND_CMD += -not \( $(call findfileclauses,libpthread*.so* $(call qstrip,$(BR2_STRIP_EXCLUDE_FILES))) \) -print target-finalize: