Patchwork build: use find -perm /mode, instead of -perm +mode STRIP_FIND_CMD

login
register
mail settings
Submitter Tzu-Jung Lee
Date June 19, 2013, 9:24 a.m.
Message ID <1371633890-21646-1-git-send-email-tjlee@ambarella.com>
Download mbox | patch
Permalink /patch/252525/
State Accepted
Headers show

Comments

Tzu-Jung Lee - June 19, 2013, 9:24 a.m.
The -perm +mode is deprecated, and sometimes yields suprising results.
It can be confused with permission in symbolic mode, for example '+u+g',
as POSIX spec suggests.

Signed-off-by: Tzu-Jung Lee <tjlee@ambarella.com>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/Makefile b/Makefile
index c514e4f..d4be0d8 100644
--- a/Makefile
+++ b/Makefile
@@ -444,7 +444,7 @@  STRIP_FIND_CMD = find $(TARGET_DIR)
 ifneq (,$(call qstrip,$(BR2_STRIP_EXCLUDE_DIRS)))
 STRIP_FIND_CMD += \( $(call finddirclauses,$(TARGET_DIR),$(call qstrip,$(BR2_STRIP_EXCLUDE_DIRS))) \) -prune -o
 endif
-STRIP_FIND_CMD += -type f -perm +111
+STRIP_FIND_CMD += -type f -perm /111
 STRIP_FIND_CMD += -not \( $(call findfileclauses,libpthread*.so* $(call qstrip,$(BR2_STRIP_EXCLUDE_FILES))) \) -print
 
 target-finalize: