Patchwork [1/1,Raring,SRU] UBUNTU: SAUCE: Work around broken ACPI backlight on ThinkPad T430

login
register
mail settings
Submitter Seth Forshee
Date June 18, 2013, 9:08 p.m.
Message ID <1371589698-31015-2-git-send-email-seth.forshee@canonical.com>
Download mbox | patch
Permalink /patch/252446/
State New
Headers show

Comments

Seth Forshee - June 18, 2013, 9:08 p.m.
Add a quirk to disable Windows 8 compatibility on this machine
to work around a broken ACPI backlight implementation.

BugLink: http://bugs.launchpad.net/bugs/1183856
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
---
 drivers/acpi/blacklist.c | 8 ++++++++
 1 file changed, 8 insertions(+)
Brad Figg - June 18, 2013, 9:15 p.m.
On 06/18/2013 02:08 PM, Seth Forshee wrote:
> Add a quirk to disable Windows 8 compatibility on this machine
> to work around a broken ACPI backlight implementation.
> 
> BugLink: http://bugs.launchpad.net/bugs/1183856
> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
> ---
>  drivers/acpi/blacklist.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
> index 13baad6..6023e51 100644
> --- a/drivers/acpi/blacklist.c
> +++ b/drivers/acpi/blacklist.c
> @@ -291,6 +291,14 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
>  	},
>  	{
>  	.callback = dmi_disable_osi_win8,
> +	.ident = "Lenovo ThinkPad T430",
> +	.matches = {
> +		     DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +		     DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad T430"),
> +		},
> +	},
> +	{
> +	.callback = dmi_disable_osi_win8,
>  	.ident = "Lenovo ThinkPad T430s",
>  	.matches = {
>  		     DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>
Stefan Bader - June 19, 2013, 6:35 a.m.
Looks to be minimal risk.
Brad Figg - June 19, 2013, 2:47 p.m.
On 06/18/2013 02:08 PM, Seth Forshee wrote:
> Add a quirk to disable Windows 8 compatibility on this machine
> to work around a broken ACPI backlight implementation.
> 
> BugLink: http://bugs.launchpad.net/bugs/1183856
> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
> ---
>  drivers/acpi/blacklist.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
> index 13baad6..6023e51 100644
> --- a/drivers/acpi/blacklist.c
> +++ b/drivers/acpi/blacklist.c
> @@ -291,6 +291,14 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
>  	},
>  	{
>  	.callback = dmi_disable_osi_win8,
> +	.ident = "Lenovo ThinkPad T430",
> +	.matches = {
> +		     DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +		     DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad T430"),
> +		},
> +	},
> +	{
> +	.callback = dmi_disable_osi_win8,
>  	.ident = "Lenovo ThinkPad T430s",
>  	.matches = {
>  		     DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
>

Patch

diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
index 13baad6..6023e51 100644
--- a/drivers/acpi/blacklist.c
+++ b/drivers/acpi/blacklist.c
@@ -291,6 +291,14 @@  static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
 	},
 	{
 	.callback = dmi_disable_osi_win8,
+	.ident = "Lenovo ThinkPad T430",
+	.matches = {
+		     DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+		     DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad T430"),
+		},
+	},
+	{
+	.callback = dmi_disable_osi_win8,
 	.ident = "Lenovo ThinkPad T430s",
 	.matches = {
 		     DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),