Patchwork sparc: tsb must be flushed before tlb

login
register
mail settings
Submitter Dave Kleikamp
Date June 18, 2013, 2:05 p.m.
Message ID <51C06930.3050800@oracle.com>
Download mbox | patch
Permalink /patch/252351/
State Accepted
Delegated to: David Miller
Headers show

Comments

Dave Kleikamp - June 18, 2013, 2:05 p.m.
This fixes a race where a cpu may re-load a tlb from a stale tsb right
after it has been flushed by a remote function call.

I still see some instability when stressing the system with parallel
kernel builds while creating memory pressure by writing to
/proc/sys/vm/nr_hugepages, but this patch improves the stability
significantly.

Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>
Acked-by: Bob Picco <bob.picco@oracle.com>
---
 arch/sparc/mm/tlb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
David Miller - June 19, 2013, 9:15 a.m.
From: Dave Kleikamp <dave.kleikamp@oracle.com>
Date: Tue, 18 Jun 2013 09:05:36 -0500

> This fixes a race where a cpu may re-load a tlb from a stale tsb right
> after it has been flushed by a remote function call.
> 
> I still see some instability when stressing the system with parallel
> kernel builds while creating memory pressure by writing to
> /proc/sys/vm/nr_hugepages, but this patch improves the stability
> significantly.
> 
> Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>
> Acked-by: Bob Picco <bob.picco@oracle.com>

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe sparclinux" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/arch/sparc/mm/tlb.c b/arch/sparc/mm/tlb.c
index 83d89bc..37e7bc4 100644
--- a/arch/sparc/mm/tlb.c
+++ b/arch/sparc/mm/tlb.c
@@ -85,8 +85,8 @@  static void tlb_batch_add_one(struct mm_struct *mm, unsigned long vaddr,
 	}
 
 	if (!tb->active) {
-		global_flush_tlb_page(mm, vaddr);
 		flush_tsb_user_page(mm, vaddr);
+		global_flush_tlb_page(mm, vaddr);
 		goto out;
 	}