From patchwork Tue Jun 18 09:46:17 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Grant Likely X-Patchwork-Id: 252203 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from ozlabs.org (localhost [IPv6:::1]) by ozlabs.org (Postfix) with ESMTP id D70D22C0565 for ; Tue, 18 Jun 2013 19:46:56 +1000 (EST) Received: by ozlabs.org (Postfix) id 8B7902C009E; Tue, 18 Jun 2013 19:46:26 +1000 (EST) Delivered-To: linuxppc-dev@ozlabs.org Received: from mail-wi0-x235.google.com (mail-wi0-x235.google.com [IPv6:2a00:1450:400c:c05::235]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id C411C2C009A for ; Tue, 18 Jun 2013 19:46:24 +1000 (EST) Received: by mail-wi0-f181.google.com with SMTP id hq4so3023867wib.2 for ; Tue, 18 Jun 2013 02:46:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:subject:to:cc:in-reply-to:references:date:message-id :x-gm-message-state; bh=ZCb2kpC8m+0+8Juyf9slbHvSg9CvIE8dEbfRYMm+Nmc=; b=WsahzDzLUDJv7Na0+fMNyFhB8Tp6FAvQdslwbVNzMkYkIw97nqkZCncpvQv1urF2zl B5ZraBcUED8ayVnV71nmHH/XBNKcRARhJkNpEyX5hcXzSRM/ozosp3iGT8tKrTRtXi5o JI65Xh/hLCsjpC4HzzT1fPkZ1dvjRPsVtgW27T1jvCQ3ArZXbOYZWapJmJ1/eQSq9Ywb uIlUU7j9d33HlblCMHKAJxXKRLOtTBTqXY1bYq7E28QIv/RwXCQqTAYawbulmeY+B9Jd W6f0/ICzUaDH3NTtAeMSwDDmqnfnFvclgkwGJUBN+5DMlUgDYGVqAjKwbb9gtXjx/cWK 4neA== X-Received: by 10.194.238.42 with SMTP id vh10mr10413997wjc.28.1371548781924; Tue, 18 Jun 2013 02:46:21 -0700 (PDT) Received: from localhost (host86-129-73-159.range86-129.btcentralplus.com. [86.129.73.159]) by mx.google.com with ESMTPSA id ay7sm729213wib.9.2013.06.18.02.46.19 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 18 Jun 2013 02:46:21 -0700 (PDT) Received: by localhost (Postfix, from userid 1000) id 9BFA93E0D88; Tue, 18 Jun 2013 10:46:17 +0100 (BST) From: Grant Likely Subject: Re: [PATCH v2 08/11] irqdomain: Refactor irq_domain_associate_many() To: Michael Neuling In-Reply-To: References: <1371244086-9189-1-git-send-email-grant.likely@linaro.org> <1371244086-9189-9-git-send-email-grant.likely@linaro.org> <4521.1371518445@ale.ozlabs.ibm.com> <5220.1371518734@ale.ozlabs.ibm.com> Date: Tue, 18 Jun 2013 10:46:17 +0100 Message-Id: <20130618094617.9BFA93E0D88@localhost> X-Gm-Message-State: ALoCoQl4et9XyTMQYRrf18ln/sSKOB/toG9pZRvhxZxyTAv+EzwZ7qyR0P367XkXCS9SwX0cfSNS Cc: Stephen Rothwell , Linux Kernel Mailing List , Linux PPC dev , linux-next , Thomas Gleixner X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, 18 Jun 2013 10:05:31 +0100, Grant Likely wrote: > On Tue, Jun 18, 2013 at 2:25 AM, Michael Neuling wrote: > > Michael Neuling wrote: > > > >> Grant, > >> > >> In next-20130617 we are getting the below crash on POWER7. Bisecting, > >> points to this patch (d39046ec72 in next) > > > > Also, reverting just d39046ec72 fixes the crash in next-20130617. > > Odd. Of all the changes in that series, I would not have expected that > one to cause any problems. I'm digging into it now... Ugh. I flubbed the commit. Try this patch. It should solve the problem: From b7ba09c29ed36eda8e16453646b55faea7f9c25f Mon Sep 17 00:00:00 2001 From: Grant Likely Date: Tue, 18 Jun 2013 10:15:19 +0100 Subject: [PATCH] irqdomain: Fix flubbed irq_domain_associate_many refactoring commit d39046ec72, "irqdomain: Refactor irq_domain_associate_many()" was missing the following hunk which causes a boot failure on anything using irq_domain_add_tree() to allocate an irq domain. Signed-off-by: Grant Likely Cc: Michael Neuling Cc: Benjamin Herrenschmidt , Cc: Thomas Gleixner , Cc: Stephen Rothwell --- include/linux/irqdomain.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/irqdomain.h b/include/linux/irqdomain.h index 02f7658..c983ed1 100644 --- a/include/linux/irqdomain.h +++ b/include/linux/irqdomain.h @@ -162,7 +162,7 @@ static inline struct irq_domain *irq_domain_add_tree(struct device_node *of_node const struct irq_domain_ops *ops, void *host_data) { - return irq_domain_add_linear(of_node, 0, ops, host_data); + return __irq_domain_add(of_node, 0, ~0, 0, ops, host_data); } extern void irq_domain_remove(struct irq_domain *host);