From patchwork Tue Jun 18 03:45:33 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: liguang X-Patchwork-Id: 252105 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id AB86D2C029D for ; Tue, 18 Jun 2013 13:48:20 +1000 (EST) Received: from localhost ([::1]:48562 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uomu1-0002Vf-LJ for incoming@patchwork.ozlabs.org; Mon, 17 Jun 2013 23:48:17 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60717) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uomtm-0002VP-Nv for qemu-devel@nongnu.org; Mon, 17 Jun 2013 23:48:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uomtl-0000Ur-HS for qemu-devel@nongnu.org; Mon, 17 Jun 2013 23:48:02 -0400 Received: from [222.73.24.84] (port=50940 helo=song.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uomtj-0000U5-9t; Mon, 17 Jun 2013 23:47:59 -0400 X-IronPort-AV: E=Sophos;i="4.87,886,1363104000"; d="scan'208";a="7584433" Received: from unknown (HELO tang.cn.fujitsu.com) ([10.167.250.3]) by song.cn.fujitsu.com with ESMTP; 18 Jun 2013 11:45:00 +0800 Received: from fnstmail02.fnst.cn.fujitsu.com (tang.cn.fujitsu.com [127.0.0.1]) by tang.cn.fujitsu.com (8.14.3/8.13.1) with ESMTP id r5I3lsxq016477; Tue, 18 Jun 2013 11:47:54 +0800 Received: from liguang.fnst.cn.fujitsu.com ([10.167.233.147]) by fnstmail02.fnst.cn.fujitsu.com (Lotus Domino Release 8.5.3) with ESMTP id 2013061811455223-2222870 ; Tue, 18 Jun 2013 11:45:52 +0800 From: liguang To: qemu-devel@nongnu.org, qemu-trivial@nongnu.org Date: Tue, 18 Jun 2013 11:45:33 +0800 Message-Id: <1371527137-16949-1-git-send-email-lig.fnst@cn.fujitsu.com> X-Mailer: git-send-email 1.7.2.5 MIME-Version: 1.0 X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/06/18 11:45:52, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/06/18 11:45:52 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 222.73.24.84 Cc: liguang Subject: [Qemu-devel] =?utf-8?q?=5BPATCH_v2_1/5=5D_vnc=3A_pass_bool_parame?= =?utf-8?q?ter_for_some_functions?= X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org last parameters of vnc_listen_read,vnc_connect are bool, so pass 'false/true' instead of '0/1' for them. Reviewed-by: Andreas Färber Signed-off-by: liguang --- ui/vnc.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index dfc7459..1a8b940 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -2889,13 +2889,13 @@ static void vnc_listen_read(void *opaque, bool websocket) static void vnc_listen_regular_read(void *opaque) { - vnc_listen_read(opaque, 0); + vnc_listen_read(opaque, false); } #ifdef CONFIG_VNC_WS static void vnc_listen_websocket_read(void *opaque) { - vnc_listen_read(opaque, 1); + vnc_listen_read(opaque, true); } #endif /* CONFIG_VNC_WS */ @@ -3283,7 +3283,7 @@ void vnc_display_open(DisplayState *ds, const char *display, Error **errp) if (csock < 0) { goto fail; } - vnc_connect(vs, csock, 0, 0); + vnc_connect(vs, csock, 0, false); } else { /* listen for connects */ char *dpy; @@ -3345,5 +3345,5 @@ void vnc_display_add_client(DisplayState *ds, int csock, int skipauth) { VncDisplay *vs = vnc_display; - vnc_connect(vs, csock, skipauth, 0); + vnc_connect(vs, csock, skipauth, false); }