From patchwork Mon Jun 17 17:45:29 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 252022 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 4B7FC2C0085 for ; Tue, 18 Jun 2013 03:49:03 +1000 (EST) Received: from localhost ([::1]:57481 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UodY5-0002e9-7u for incoming@patchwork.ozlabs.org; Mon, 17 Jun 2013 13:49:01 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46956) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UodVL-0006sA-De for qemu-devel@nongnu.org; Mon, 17 Jun 2013 13:46:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UodVI-0003vq-JQ for qemu-devel@nongnu.org; Mon, 17 Jun 2013 13:46:11 -0400 Received: from mail-gh0-x22a.google.com ([2607:f8b0:4002:c05::22a]:43330) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UodVI-0003vk-Ek; Mon, 17 Jun 2013 13:46:08 -0400 Received: by mail-gh0-f170.google.com with SMTP id z10so1039788ghb.15 for ; Mon, 17 Jun 2013 10:46:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=XAkN+quend4mzb+V2Qkep8ZVbP0R/Erzl7q+Hq8MDZ4=; b=neN4O7bWpZtthHUVyO0bMpy5BBAtpBkg3xUt1oJ4Qq5bXNQX1H9HZl42rMs1HvH/MS t1JhiEpOselgpDdvNeuclIWxGbWa4/TNiYZ4bXdUS2rW2ZairLZxsMzzGM6CiEHFMsts GHNBbMk1fzRnQtp1bJdLzFqMMe81C5IsDs9CUBlDu8gwTKK5nCKnMAfgJ5P2TWl7NA0h qG+Q2/+J2v8NNRuDXORVIvanj8QKZwMbivTKdpXOdLBI4Bah3wBq/ggf49DzanV8dQDO 7jnX4VcgXkmWLl6m8aBtAdZVOtBrY+j9uQrRAUAxPCDayO5Afo4GiBkO6ellTEyayWYD r1fw== X-Received: by 10.236.153.233 with SMTP id f69mr8437754yhk.76.1371491167945; Mon, 17 Jun 2013 10:46:07 -0700 (PDT) Received: from anchor.com (50-194-63-110-static.hfc.comcastbusiness.net. [50.194.63.110]) by mx.google.com with ESMTPSA id g39sm25692426yhb.13.2013.06.17.10.46.05 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 17 Jun 2013 10:46:07 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 17 Jun 2013 10:45:29 -0700 Message-Id: <1371491129-30246-5-git-send-email-rth@twiddle.net> X-Mailer: git-send-email 1.8.1.4 In-Reply-To: <1371491129-30246-1-git-send-email-rth@twiddle.net> References: <1371491129-30246-1-git-send-email-rth@twiddle.net> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4002:c05::22a Cc: aliguori@us.ibm.com, Anton Blanchard , qemu-stable@nongnu.org Subject: [Qemu-devel] [PULL 4/4] tcg-ppc64: rotr_i32 rotates wrong amount X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Anton Blanchard rotr_i32 calculates the amount to left shift and puts it into a temporary, but then doesn't use it when doing the shift. Cc: qemu-stable@nongnu.org Signed-off-by: Anton Blanchard Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 5cdff36..606b73d 100644 --- a/tcg/ppc64/tcg-target.c +++ b/tcg/ppc64/tcg-target.c @@ -1662,7 +1662,7 @@ static void tcg_out_op (TCGContext *s, TCGOpcode opc, const TCGArg *args, tcg_out_rlw(s, RLWINM, args[0], args[1], 32 - args[2], 0, 31); } else { tcg_out32(s, SUBFIC | TAI(0, args[2], 32)); - tcg_out32(s, RLWNM | SAB(args[1], args[0], args[2]) + tcg_out32(s, RLWNM | SAB(args[1], args[0], 0) | MB(0) | ME(31)); } break;