From patchwork Mon Jun 17 16:38:26 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anthony PERARD X-Patchwork-Id: 251926 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id BD4982C0174 for ; Tue, 18 Jun 2013 02:39:13 +1000 (EST) Received: from localhost ([::1]:58950 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UocSV-00077y-4R for incoming@patchwork.ozlabs.org; Mon, 17 Jun 2013 12:39:11 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58318) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UocSE-00077o-WF for qemu-devel@nongnu.org; Mon, 17 Jun 2013 12:38:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UocSD-0006re-U9 for qemu-devel@nongnu.org; Mon, 17 Jun 2013 12:38:54 -0400 Received: from smtp.citrix.com ([66.165.176.89]:39592) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UocSA-0006qu-Ju; Mon, 17 Jun 2013 12:38:50 -0400 X-IronPort-AV: E=Sophos;i="4.87,882,1363132800"; d="scan'208";a="31621633" Received: from accessns.citrite.net (HELO FTLPEX01CL02.citrite.net) ([10.9.154.239]) by FTLPIPO01.CITRIX.COM with ESMTP/TLS/AES128-SHA; 17 Jun 2013 16:38:48 +0000 Received: from ukmail1.uk.xensource.com (10.80.16.128) by smtprelay.citrix.com (10.13.107.79) with Microsoft SMTP Server id 14.2.342.4; Mon, 17 Jun 2013 12:38:47 -0400 Received: from [10.80.3.61] (helo=perard.uk.xensource.com) by ukmail1.uk.xensource.com with esmtp (Exim 4.69) (envelope-from ) id 1UocS8-0003r4-4F; Mon, 17 Jun 2013 17:38:48 +0100 From: Anthony PERARD To: QEMU-devel Date: Mon, 17 Jun 2013 17:38:26 +0100 Message-ID: <1371487106-17194-1-git-send-email-anthony.perard@citrix.com> X-Mailer: git-send-email 1.8.2.3 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 66.165.176.89 Cc: qemu-trivial@nongnu.org, Anthony PERARD , Gerd Hoffmann Subject: [Qemu-devel] [PATCH] qxl: Fix QXLRam initialisation. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org The qxl driver expect NULL for QXLRam.memory_configs, but this is never initialized. If memory is set to 0xc2c2.., it leads to a spice-critical error when trying to start qxl. Signed-off-by: Anthony PERARD Reviewed-by: Gerd Hoffmann --- hw/display/qxl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/display/qxl.c b/hw/display/qxl.c index c475cb1..937a402 100644 --- a/hw/display/qxl.c +++ b/hw/display/qxl.c @@ -387,6 +387,7 @@ static void init_qxl_ram(PCIQXLDevice *d) d->ram->int_pending = cpu_to_le32(0); d->ram->int_mask = cpu_to_le32(0); d->ram->update_surface = 0; + d->ram->monitors_config = 0; SPICE_RING_INIT(&d->ram->cmd_ring); SPICE_RING_INIT(&d->ram->cursor_ring); SPICE_RING_INIT(&d->ram->release_ring);