From patchwork Thu Mar 26 22:58:45 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chuck Ebbert X-Patchwork-Id: 25182 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id DB5D1DDDEE for ; Fri, 27 Mar 2009 10:02:51 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760211AbZCZXBM (ORCPT ); Thu, 26 Mar 2009 19:01:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761560AbZCZXBJ (ORCPT ); Thu, 26 Mar 2009 19:01:09 -0400 Received: from mx2.redhat.com ([66.187.237.31]:54059 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761524AbZCZXBI (ORCPT ); Thu, 26 Mar 2009 19:01:08 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n2QMwwEp017894; Thu, 26 Mar 2009 18:59:00 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n2QMwpG2016426; Thu, 26 Mar 2009 18:58:51 -0400 Received: from dhcp-100-2-144.bos.redhat.com (dhcp-100-2-144.bos.redhat.com [10.16.2.144]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n2QMwvjm023780; Thu, 26 Mar 2009 18:58:58 -0400 Date: Thu, 26 Mar 2009 18:58:45 -0400 From: Chuck Ebbert To: Herbert Xu Cc: netdev@vger.kernel.org Subject: [patch] xfrm: spin_lock() should be spin_unlock() in xfrm_state.c Message-ID: <20090326185845.2c5719b4@dhcp-100-2-144.bos.redhat.com> Organization: Red Hat, Inc. Mime-Version: 1.0 X-Scanned-By: MIMEDefang 2.58 on 172.16.27.26 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org xfrm: spin_lock() should be spin_unlock() in xfrm_state.c spin_lock() should be spin_unlock() in xfrm_state_walk_done(). caused by: commit 12a169e7d8f4b1c95252d8b04ed0f1033ed7cfe2 "ipsec: Put dumpers on the dump list" Reported-by: Marc Milgram Signed-off-by: Chuck Ebbert --- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- linux-2.6.29.noarch.orig/net/xfrm/xfrm_state.c +++ linux-2.6.29.noarch/net/xfrm/xfrm_state.c @@ -1615,7 +1615,7 @@ void xfrm_state_walk_done(struct xfrm_st spin_lock_bh(&xfrm_state_lock); list_del(&walk->all); - spin_lock_bh(&xfrm_state_lock); + spin_unlock_bh(&xfrm_state_lock); } EXPORT_SYMBOL(xfrm_state_walk_done);