Patchwork xfrm: spin_lock() should be spin_unlock() in xfrm_state.c

login
register
mail settings
Submitter Chuck Ebbert
Date March 26, 2009, 10:58 p.m.
Message ID <20090326185845.2c5719b4@dhcp-100-2-144.bos.redhat.com>
Download mbox | patch
Permalink /patch/25182/
State Accepted
Delegated to: David Miller
Headers show

Comments

Chuck Ebbert - March 26, 2009, 10:58 p.m.
xfrm: spin_lock() should be spin_unlock() in xfrm_state.c

spin_lock() should be spin_unlock() in xfrm_state_walk_done().

caused by:
commit 12a169e7d8f4b1c95252d8b04ed0f1033ed7cfe2
"ipsec: Put dumpers on the dump list"

Reported-by: Marc Milgram <mmilgram@redhat.com>
Signed-off-by: Chuck Ebbert <cebbert@redhat.com>
---

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Herbert Xu - March 27, 2009, 1:16 a.m.
On Thu, Mar 26, 2009 at 06:58:45PM -0400, Chuck Ebbert wrote:
> xfrm: spin_lock() should be spin_unlock() in xfrm_state.c
> 
> spin_lock() should be spin_unlock() in xfrm_state_walk_done().
> 
> caused by:
> commit 12a169e7d8f4b1c95252d8b04ed0f1033ed7cfe2
> "ipsec: Put dumpers on the dump list"
> 
> Reported-by: Marc Milgram <mmilgram@redhat.com>
> Signed-off-by: Chuck Ebbert <cebbert@redhat.com>
> ---
> 
> --- linux-2.6.29.noarch.orig/net/xfrm/xfrm_state.c
> +++ linux-2.6.29.noarch/net/xfrm/xfrm_state.c
> @@ -1615,7 +1615,7 @@ void xfrm_state_walk_done(struct xfrm_st
>  
>  	spin_lock_bh(&xfrm_state_lock);
>  	list_del(&walk->all);
> -	spin_lock_bh(&xfrm_state_lock);
> +	spin_unlock_bh(&xfrm_state_lock);
>  }
>  EXPORT_SYMBOL(xfrm_state_walk_done);

Good catch!

Thanks,
David Miller - March 27, 2009, 7:24 a.m.
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Fri, 27 Mar 2009 09:16:54 +0800

> On Thu, Mar 26, 2009 at 06:58:45PM -0400, Chuck Ebbert wrote:
> > xfrm: spin_lock() should be spin_unlock() in xfrm_state.c
> > 
> > spin_lock() should be spin_unlock() in xfrm_state_walk_done().
> > 
> > caused by:
> > commit 12a169e7d8f4b1c95252d8b04ed0f1033ed7cfe2
> > "ipsec: Put dumpers on the dump list"
> > 
> > Reported-by: Marc Milgram <mmilgram@redhat.com>
> > Signed-off-by: Chuck Ebbert <cebbert@redhat.com>
 ...
> Good catch!

Applied and queued to -stable.

I can't believe nobody hit this in all of this time :-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Herbert Xu - March 27, 2009, 7:38 a.m.
On Fri, Mar 27, 2009 at 12:24:13AM -0700, David Miller wrote:
>
> I can't believe nobody hit this in all of this time :-)

Indeed, now it makes nervous everytime I type ip xfrm state :)

Patch

--- linux-2.6.29.noarch.orig/net/xfrm/xfrm_state.c
+++ linux-2.6.29.noarch/net/xfrm/xfrm_state.c
@@ -1615,7 +1615,7 @@  void xfrm_state_walk_done(struct xfrm_st
 
 	spin_lock_bh(&xfrm_state_lock);
 	list_del(&walk->all);
-	spin_lock_bh(&xfrm_state_lock);
+	spin_unlock_bh(&xfrm_state_lock);
 }
 EXPORT_SYMBOL(xfrm_state_walk_done);