Patchwork appletalk: this warning can go I think

login
register
mail settings
Submitter Alan Cox
Date March 26, 2009, 8:49 p.m.
Message ID <20090326204858.4910.28079.stgit@localhost.localdomain>
Download mbox | patch
Permalink /patch/25179/
State Accepted
Delegated to: David Miller
Headers show

Comments

Alan Cox - March 26, 2009, 8:49 p.m.
Its past 2.2 ...

Signed-off-by: Alan Cox <alan@lxorguk.ukuu.org.uk?>
---

 net/appletalk/ddp.c |    6 +-----
 1 files changed, 1 insertions(+), 5 deletions(-)



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - March 27, 2009, 7:27 a.m.
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Date: Thu, 26 Mar 2009 20:49:02 +0000

> Its past 2.2 ...
> 
> Signed-off-by: Alan Cox <alan@lxorguk.ukuu.org.uk>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c
index 5abce07..3104be8 100644
--- a/net/appletalk/ddp.c
+++ b/net/appletalk/ddp.c
@@ -1571,14 +1571,10 @@  static int atalk_sendmsg(struct kiocb *iocb, struct socket *sock, struct msghdr
 		    usat->sat_family != AF_APPLETALK)
 			return -EINVAL;
 
-		/* netatalk doesn't implement this check */
+		/* netatalk didn't implement this check */
 		if (usat->sat_addr.s_node == ATADDR_BCAST &&
 		    !sock_flag(sk, SOCK_BROADCAST)) {
-			printk(KERN_INFO "SO_BROADCAST: Fix your netatalk as "
-					 "it will break before 2.2\n");
-#if 0
 			return -EPERM;
-#endif
 		}
 	} else {
 		if (sk->sk_state != TCP_ESTABLISHED)