Patchwork [2/2] pvpanic: fix fwcfg for big endian hosts

login
register
mail settings
Submitter Michael S. Tsirkin
Date June 16, 2013, 8:59 p.m.
Message ID <1371416189-29563-2-git-send-email-mst@redhat.com>
Download mbox | patch
Permalink /patch/251742/
State New
Headers show

Comments

Michael S. Tsirkin - June 16, 2013, 8:59 p.m.
Convert port number to little endian when
exposing it in fw cfg.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 hw/misc/pvpanic.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Patch

diff --git a/hw/misc/pvpanic.c b/hw/misc/pvpanic.c
index 9ed9897..151eefe 100644
--- a/hw/misc/pvpanic.c
+++ b/hw/misc/pvpanic.c
@@ -106,12 +106,13 @@  int pvpanic_init(ISABus *bus)
     ISADevice *dev = isa_create_simple(bus, TYPE_ISA_PVPANIC_DEVICE);
     PVPanicState *s = ISA_PVPANIC_DEVICE(dev);
     FWCfgState *fw_cfg = fw_cfg_find();
+    uint16_t *pvpanic_port = g_malloc(sizeof(*pvpanic_port));
+    *pvpanic_port = cpu_to_le16(s->ioport);
 
     assert(fw_cfg);
 
-    fw_cfg_add_file(fw_cfg, "etc/pvpanic-port",
-                    g_memdup(&s->ioport, sizeof(s->ioport)),
-                    sizeof(s->ioport));
+    fw_cfg_add_file(fw_cfg, "etc/pvpanic-port", pvpanic_port,
+                    sizeof(*pvpanic_port));
 
     return 0;
 }