From patchwork Sun Jun 16 16:10:34 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagannadha Sutradharudu Teki X-Patchwork-Id: 251711 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id F04082C00AF for ; Mon, 17 Jun 2013 02:11:41 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 5A3944A039; Sun, 16 Jun 2013 18:11:38 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yywSR4Djxksf; Sun, 16 Jun 2013 18:11:38 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 0EEC94A02D; Sun, 16 Jun 2013 18:11:24 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 6AC0F4A02D for ; Sun, 16 Jun 2013 18:11:03 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7XYXPYD6EvMG for ; Sun, 16 Jun 2013 18:10:55 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 BL_NJABL=ERR(-1.5) (only DNSBL check requested) Received: from ch1outboundpool.messaging.microsoft.com (ch1ehsobe001.messaging.microsoft.com [216.32.181.181]) by theia.denx.de (Postfix) with ESMTPS id 370CB4A029 for ; Sun, 16 Jun 2013 18:10:48 +0200 (CEST) Received: from mail74-ch1-R.bigfish.com (10.43.68.239) by CH1EHSOBE011.bigfish.com (10.43.70.61) with Microsoft SMTP Server id 14.1.225.23; Sun, 16 Jun 2013 16:10:40 +0000 Received: from mail74-ch1 (localhost [127.0.0.1]) by mail74-ch1-R.bigfish.com (Postfix) with ESMTP id 62AE5140360; Sun, 16 Jun 2013 16:10:40 +0000 (UTC) X-Forefront-Antispam-Report: CIP:149.199.60.83; KIP:(null); UIP:(null); IPV:NLI; H:xsj-gw1; RD:unknown-60-83.xilinx.com; EFVD:NLI X-SpamScore: 4 X-BigFish: VPS4(zz98dIc85fh4015Izz1f42h1ee6h1de0h1fdah1202h1e76h1d1ah1d2ah1fc6hzz17326ah18c673h1954cbh8275bh1bdf24mz2fh95h668h839hd24hf0ah119dh1288h12a5h12bdh137ah1441h14ddh1504h1537h153bh162dh1631h1758h18e1h1946h19b5h1b0ah1bceh1d0ch1d2eh1d3fh1dfeh1dffh1e1dh906i1155h192ch) Received-SPF: pass (mail74-ch1: domain of xilinx.com designates 149.199.60.83 as permitted sender) client-ip=149.199.60.83; envelope-from=jagannadha.sutradharudu-teki@xilinx.com; helo=xsj-gw1 ; helo=xsj-gw1 ; Received: from mail74-ch1 (localhost.localdomain [127.0.0.1]) by mail74-ch1 (MessageSwitch) id 1371399038464972_8506; Sun, 16 Jun 2013 16:10:38 +0000 (UTC) Received: from CH1EHSMHS008.bigfish.com (snatpool1.int.messaging.microsoft.com [10.43.68.245]) by mail74-ch1.bigfish.com (Postfix) with ESMTP id 6916F32005A; Sun, 16 Jun 2013 16:10:38 +0000 (UTC) Received: from xsj-gw1 (149.199.60.83) by CH1EHSMHS008.bigfish.com (10.43.70.8) with Microsoft SMTP Server id 14.1.225.23; Sun, 16 Jun 2013 16:10:38 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-smtp1.xilinx.com) by xsj-gw1 with esmtp (Exim 4.63) (envelope-from ) id 1UoFXJ-000070-TD; Sun, 16 Jun 2013 09:10:37 -0700 From: Jagannadha Sutradharudu Teki To: Joel A Fernandes Thread-Topic: [U-Boot] [PATCH] checkpatch.pl: Do not hardcode perl path Thread-Index: AQHOaqhrl2ZL/0iaWk+zyTQLuDXZLJk4gmyA Date: Sun, 16 Jun 2013 16:10:34 +0000 References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.23.230.59] MIME-Version: 1.0 X-RCIS-Action: ALLOW Message-ID: X-OriginatorOrg: xilinx.com X-Content-Filtered-By: Mailman/MimeDel 2.1.11 Cc: Tom Rini , "u-boot@lists.denx.de" Subject: Re: [U-Boot] [PATCH] checkpatch.pl: Do not hardcode perl path X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de From: Joel A Fernandes [mailto:agnel.joel@gmail.com] Sent: 16 June 2013 21:15 To: Jagannadha Sutradharudu Teki Cc: u-boot@lists.denx.de; Tom Rini Subject: Re: [U-Boot] [PATCH] checkpatch.pl: Do not hardcode perl path On Sunday, June 16, 2013, Jagannadha Sutradharudu Teki wrote: From: Jagannadha Sutradharudu Teki checkpatch.pl requires perl v5.10.0 to run but it doesn't require to place in /usr/bin/perl Use env to ensure that the interpreter used is the first one on environment's $PATH on system with several versions of perl installed. Signed-off-by: Jagannadha Sutradharudu Teki --- tools/checkpatch.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) # (c) 2001, Dave Jones. (the file handling bit) # (c) 2005, Joel Schopp (the ugly bit) # (c) 2007,2008, Andy Whitcroft (new conditions, test suite) # (c) 2008-2010 Andy Whitcroft # Licensed under the terms of the GNU GPL License version 2 +use warnings; use strict; my $P = $0; -- 1.8.3 diff --git a/tools/checkpatch.pl b/tools/checkpatch.pl index 896e2bc..8dc5b9c 100755 --- a/tools/checkpatch.pl +++ b/tools/checkpatch.pl @@ -1,10 +1,11 @@ -#!/usr/bin/perl -w +#!/usr/bin/env perl Would it not work to pass in the -w here? Yes it will not work just to pass -w It's taking -w as a file. Thanks, Jagan. Joel