Patchwork [U-Boot] gpio: altera_pio: Fix inversed logic of gpio_is_valid() implementation

login
register
mail settings
Submitter Axel Lin
Date June 15, 2013, 9:10 a.m.
Message ID <1371287438.4051.2.camel@phoenix>
Download mbox | patch
Permalink /patch/251592/
State New
Delegated to: Thomas Chou
Headers show

Comments

Axel Lin - June 15, 2013, 9:10 a.m.
The implementation of gpio_is_valid() has inversed logic, fix it.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
Hi,
I don't have this hardware to test, but current code looks obviously wrong.
I'd appreciate if someone can review and test this patch.

Axel
 drivers/gpio/altera_pio.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Albert ARIBAUD - July 29, 2013, 9:16 a.m.
Hi Axel,

On Sat, 15 Jun 2013 17:10:38 +0800, Axel Lin <axel.lin@ingics.com>
wrote:

> The implementation of gpio_is_valid() has inversed logic, fix it.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> Hi,
> I don't have this hardware to test, but current code looks obviously wrong.
> I'd appreciate if someone can review and test this patch.
> 
> Axel
>  drivers/gpio/altera_pio.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Not sure why this was assigned to me, as this is not ARM related.
Delegating to Thomas Chou as the NIOS(II) custodian and Cc:ing him, as
well as Scott McNutt, nios2-generic maintainer.

> diff --git a/drivers/gpio/altera_pio.c b/drivers/gpio/altera_pio.c
> index fb03760..7ab6df8 100644
> --- a/drivers/gpio/altera_pio.c
> +++ b/drivers/gpio/altera_pio.c
> @@ -294,6 +294,6 @@ int gpio_is_valid(int number)
>  	int gidx = altera_pio_gidx(number);
>  
>  	if (gidx < 0)
> -		return 1;
> -	return 0;
> +		return 0;
> +	return 1;
>  }

Amicalement,
Axel Lin - Aug. 5, 2013, 12:26 a.m.
2013/7/29 Albert ARIBAUD <albert.u.boot@aribaud.net>:
> Hi Axel,
>
> On Sat, 15 Jun 2013 17:10:38 +0800, Axel Lin <axel.lin@ingics.com>
> wrote:
>
>> The implementation of gpio_is_valid() has inversed logic, fix it.
>>
>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>> ---
>> Hi,
>> I don't have this hardware to test, but current code looks obviously wrong.
>> I'd appreciate if someone can review and test this patch.
>>
>> Axel
>>  drivers/gpio/altera_pio.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> Not sure why this was assigned to me, as this is not ARM related.
> Delegating to Thomas Chou as the NIOS(II) custodian and Cc:ing him, as
> well as Scott McNutt, nios2-generic maintainer.

I guess it is just because there is no response from both Thomas Chou and
Scott McNutt. I have CCed them when submitted the patch.
Checking the maillist archive, seems no email from Thomas Chou and Scott McNutt
in 2013. So I have no idea who will pick up this patch.

Regards,
Axel

Patch

diff --git a/drivers/gpio/altera_pio.c b/drivers/gpio/altera_pio.c
index fb03760..7ab6df8 100644
--- a/drivers/gpio/altera_pio.c
+++ b/drivers/gpio/altera_pio.c
@@ -294,6 +294,6 @@  int gpio_is_valid(int number)
 	int gidx = altera_pio_gidx(number);
 
 	if (gidx < 0)
-		return 1;
-	return 0;
+		return 0;
+	return 1;
 }