Patchwork [GIT,PULL] Keystone SOC support for 3.11

login
register
mail settings
Submitter Santosh Shilimkar
Date June 15, 2013, 12:15 a.m.
Message ID <1371255346-3000-1-git-send-email-santosh.shilimkar@ti.com>
Download mbox
Permalink /patch/251563/
State New
Headers show

Pull-request

git://git.kernel.org/pub/scm/linux/kernel/git/ssantosh/linux-keystone.git tags/keystone-soc-for-arm-soc

Comments

Santosh Shilimkar - June 15, 2013, 12:15 a.m.
The following changes since commit d683b96b072dc4680fc74964eca77e6a23d1fa6e:

  Linux 3.10-rc4 (2013-06-02 17:11:17 +0900)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/ssantosh/linux-keystone.git tags/keystone-soc-for-arm-soc

for you to fetch changes up to cc92fc07c26c1bec1abb58f0cd356b13dc00a28c:

  ARM: dts: keystone: Add minimal Keystone SOC device tree data (2013-06-14 19:45:46 -0400)

----------------------------------------------------------------
SOC support for Keystone II devices:

- Minimal machine and device-tree support with arch_timers and console UART
- Reboot hook using PLL reset
- Low level debug support using UART
- SMP boot support

----------------------------------------------------------------
Santosh Shilimkar (3):
      ARM: keystone: Add minimal TI Keystone platform support
      ARM: keystone: Enable SMP support on Keystone machines
      ARM: dts: keystone: Add minimal Keystone SOC device tree data

 .../devicetree/bindings/arm/keystone/keystone.txt  |   10 ++
 arch/arm/Kconfig                                   |    3 +
 arch/arm/Kconfig.debug                             |   16 ++
 arch/arm/Makefile                                  |    1 +
 arch/arm/boot/dts/keystone.dts                     |  109 ++++++++++++++
 arch/arm/configs/keystone_defconfig                |  157 ++++++++++++++++++++
 arch/arm/include/debug/keystone.S                  |   43 ++++++
 arch/arm/mach-keystone/Kconfig                     |   15 ++
 arch/arm/mach-keystone/Makefile                    |    2 +
 arch/arm/mach-keystone/Makefile.boot               |    1 +
 arch/arm/mach-keystone/keystone.c                  |   77 ++++++++++
 arch/arm/mach-keystone/keystone.h                  |   17 +++
 arch/arm/mach-keystone/platsmp.c                   |   52 +++++++
 13 files changed, 503 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/keystone/keystone.txt
 create mode 100644 arch/arm/boot/dts/keystone.dts
 create mode 100644 arch/arm/configs/keystone_defconfig
 create mode 100644 arch/arm/include/debug/keystone.S
 create mode 100644 arch/arm/mach-keystone/Kconfig
 create mode 100644 arch/arm/mach-keystone/Makefile
 create mode 100644 arch/arm/mach-keystone/Makefile.boot
 create mode 100644 arch/arm/mach-keystone/keystone.c
 create mode 100644 arch/arm/mach-keystone/keystone.h
 create mode 100644 arch/arm/mach-keystone/platsmp.c
Santosh Shilimkar - June 17, 2013, 10:46 p.m.
Olof,

On Friday 14 June 2013 08:15 PM, Santosh Shilimkar wrote:
> The following changes since commit d683b96b072dc4680fc74964eca77e6a23d1fa6e:
> 
>   Linux 3.10-rc4 (2013-06-02 17:11:17 +0900)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/ssantosh/linux-keystone.git tags/keystone-soc-for-arm-soc
>
Updated patches with your acks are pushed with the same tag as above.

 
> for you to fetch changes up to cc92fc07c26c1bec1abb58f0cd356b13dc00a28c:
> 
>   ARM: dts: keystone: Add minimal Keystone SOC device tree data (2013-06-14 19:45:46 -0400)
> 
> ----------------------------------------------------------------
> SOC support for Keystone II devices:
> 
> - Minimal machine and device-tree support with arch_timers and console UART
> - Reboot hook using PLL reset
> - Low level debug support using UART
> - SMP boot support
> 
> ----------------------------------------------------------------
> Santosh Shilimkar (3):
>       ARM: keystone: Add minimal TI Keystone platform support
>       ARM: keystone: Enable SMP support on Keystone machines
>       ARM: dts: keystone: Add minimal Keystone SOC device tree data
> 
>  .../devicetree/bindings/arm/keystone/keystone.txt  |   10 ++
>  arch/arm/Kconfig                                   |    3 +
>  arch/arm/Kconfig.debug                             |   16 ++
>  arch/arm/Makefile                                  |    1 +
>  arch/arm/boot/dts/keystone.dts                     |  109 ++++++++++++++
>  arch/arm/configs/keystone_defconfig                |  157 ++++++++++++++++++++
>  arch/arm/include/debug/keystone.S                  |   43 ++++++
>  arch/arm/mach-keystone/Kconfig                     |   15 ++
>  arch/arm/mach-keystone/Makefile                    |    2 +
>  arch/arm/mach-keystone/Makefile.boot               |    1 +
>  arch/arm/mach-keystone/keystone.c                  |   77 ++++++++++
>  arch/arm/mach-keystone/keystone.h                  |   17 +++
>  arch/arm/mach-keystone/platsmp.c                   |   52 +++++++
>  13 files changed, 503 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/arm/keystone/keystone.txt
>  create mode 100644 arch/arm/boot/dts/keystone.dts
>  create mode 100644 arch/arm/configs/keystone_defconfig
>  create mode 100644 arch/arm/include/debug/keystone.S
>  create mode 100644 arch/arm/mach-keystone/Kconfig
>  create mode 100644 arch/arm/mach-keystone/Makefile
>  create mode 100644 arch/arm/mach-keystone/Makefile.boot
>  create mode 100644 arch/arm/mach-keystone/keystone.c
>  create mode 100644 arch/arm/mach-keystone/keystone.h
>  create mode 100644 arch/arm/mach-keystone/platsmp.c
>
Olof Johansson - June 18, 2013, 7:28 a.m.
On Mon, Jun 17, 2013 at 06:46:39PM -0400, Santosh Shilimkar wrote:
> Olof,
> 
> On Friday 14 June 2013 08:15 PM, Santosh Shilimkar wrote:
> > The following changes since commit d683b96b072dc4680fc74964eca77e6a23d1fa6e:
> > 
> >   Linux 3.10-rc4 (2013-06-02 17:11:17 +0900)
> > 
> > are available in the git repository at:
> > 
> >   git://git.kernel.org/pub/scm/linux/kernel/git/ssantosh/linux-keystone.git tags/keystone-soc-for-arm-soc
> >
> Updated patches with your acks are pushed with the same tag as above.

Thanks. I don't see any outstanding review comments on this from anyone. I've
pulled this in under next/soc for 3.11.


-Olof
Santosh Shilimkar - June 18, 2013, 2:43 p.m.
On Tuesday 18 June 2013 03:28 AM, Olof Johansson wrote:
> On Mon, Jun 17, 2013 at 06:46:39PM -0400, Santosh Shilimkar wrote:
>> Olof,
>>
>> On Friday 14 June 2013 08:15 PM, Santosh Shilimkar wrote:
>>> The following changes since commit d683b96b072dc4680fc74964eca77e6a23d1fa6e:
>>>
>>>   Linux 3.10-rc4 (2013-06-02 17:11:17 +0900)
>>>
>>> are available in the git repository at:
>>>
>>>   git://git.kernel.org/pub/scm/linux/kernel/git/ssantosh/linux-keystone.git tags/keystone-soc-for-arm-soc
>>>
>> Updated patches with your acks are pushed with the same tag as above.
> 
> Thanks. I don't see any outstanding review comments on this from anyone. I've
> pulled this in under next/soc for 3.11.
> 
Thanks.

Regards,
Santosh
Arnd Bergmann - June 21, 2013, 4:19 p.m.
On Saturday 15 June 2013, Santosh Shilimkar wrote:
> The following changes since commit d683b96b072dc4680fc74964eca77e6a23d1fa6e:
> 
>   Linux 3.10-rc4 (2013-06-02 17:11:17 +0900)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/ssantosh/linux-keystone.git tags/keystone-soc-for-arm-soc
> 
> for you to fetch changes up to cc92fc07c26c1bec1abb58f0cd356b13dc00a28c:
> 
>   ARM: dts: keystone: Add minimal Keystone SOC device tree data (2013-06-14 19:45:46 -0400)
> 
> ----------------------------------------------------------------
> SOC support for Keystone II devices:
> 
> - Minimal machine and device-tree support with arch_timers and console UART
> - Reboot hook using PLL reset
> - Low level debug support using UART
> - SMP boot support

I'm getting a build warning with keystone_defconfig that I have not 
encountered before:

arch/arm/mm/fault.c:495:1: warning: 'do_sect_fault' defined but not used [-Wunused-function]
 do_sect_fault(unsigned long addr, unsigned int fsr, struct pt_regs *regs)
 ^

Any idea what is going on here and what the fix is? Should that function
just be hidden in #ifndef CONFIG_ARM_LPAE?

	Arnd
Steve Capper - June 24, 2013, 8:11 a.m.
On Fri, Jun 21, 2013 at 06:19:36PM +0200, Arnd Bergmann wrote:
> On Saturday 15 June 2013, Santosh Shilimkar wrote:
> > The following changes since commit d683b96b072dc4680fc74964eca77e6a23d1fa6e:
> > 
> >   Linux 3.10-rc4 (2013-06-02 17:11:17 +0900)
> > 
> > are available in the git repository at:
> > 
> >   git://git.kernel.org/pub/scm/linux/kernel/git/ssantosh/linux-keystone.git tags/keystone-soc-for-arm-soc
> > 
> > for you to fetch changes up to cc92fc07c26c1bec1abb58f0cd356b13dc00a28c:
> > 
> >   ARM: dts: keystone: Add minimal Keystone SOC device tree data (2013-06-14 19:45:46 -0400)
> > 
> > ----------------------------------------------------------------
> > SOC support for Keystone II devices:
> > 
> > - Minimal machine and device-tree support with arch_timers and console UART
> > - Reboot hook using PLL reset
> > - Low level debug support using UART
> > - SMP boot support
> 
> I'm getting a build warning with keystone_defconfig that I have not 
> encountered before:
> 
> arch/arm/mm/fault.c:495:1: warning: 'do_sect_fault' defined but not used [-Wunused-function]
>  do_sect_fault(unsigned long addr, unsigned int fsr, struct pt_regs *regs)
>  ^
> 
> Any idea what is going on here and what the fix is? Should that function
> just be hidden in #ifndef CONFIG_ARM_LPAE?

Many apologies, I think this was introduced by my huge page patches. For
transparent hugepages to function correctly, access flag faults need to be
handled by do_page_fault rather than do_sect_fault. Even without THP enabled
the standard page fault handler is safe to use, so I removed the do_sect_fault
entry from fsr-3level.c.

Originally I had non-LPAE huge page code too in the series and one of those
patches re-wired fsr-2level.c and then completely removed do_sect_fault.

When I split the patch series I didn't spot that do_sect_fault was in limbo for
LPAE.

I think the do_sect_fault can safely be surrounded by #ifndef CONFIG_ARM_LPAE.
Should I send a patch to do this?

Thanks,
Arnd Bergmann - June 24, 2013, 8:16 a.m.
On Monday 24 June 2013 09:11:08 Steve Capper wrote:
> 
> Many apologies, I think this was introduced by my huge page patches. For
> transparent hugepages to function correctly, access flag faults need to be
> handled by do_page_fault rather than do_sect_fault. Even without THP enabled
> the standard page fault handler is safe to use, so I removed the do_sect_fault
> entry from fsr-3level.c.
> 
> Originally I had non-LPAE huge page code too in the series and one of those
> patches re-wired fsr-2level.c and then completely removed do_sect_fault.
>
> When I split the patch series I didn't spot that do_sect_fault was in limbo for
> LPAE.

Ok, I see.
 
> I think the do_sect_fault can safely be surrounded by #ifndef CONFIG_ARM_LPAE.
> Should I send a patch to do this?

Yes, that would be good. Please add it to Russell's patch tracker once
you get an ack.

	Arnd