From patchwork Thu Mar 26 13:59:51 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yevgeny Petrilin X-Patchwork-Id: 25155 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 90BFADDDA9 for ; Fri, 27 Mar 2009 01:01:06 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757400AbZCZOAz (ORCPT ); Thu, 26 Mar 2009 10:00:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757340AbZCZOAz (ORCPT ); Thu, 26 Mar 2009 10:00:55 -0400 Received: from mail.mellanox.co.il ([194.90.237.43]:53479 "EHLO mellanox.co.il" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757303AbZCZOAy (ORCPT ); Thu, 26 Mar 2009 10:00:54 -0400 Received: from Internal Mail-Server by MTLPINE1 (envelope-from yevgenyp@mellanox.co.il) with SMTP; 26 Mar 2009 16:00:49 +0200 Received: from [10.4.3.12] ([10.4.3.12]) by mtlexch01.mtl.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 26 Mar 2009 16:00:49 +0200 Message-ID: <49CB8A57.8050507@mellanox.co.il> Date: Thu, 26 Mar 2009 15:59:51 +0200 From: Yevgeny Petrilin User-Agent: Thunderbird 2.0.0.17 (X11/20080914) MIME-Version: 1.0 To: davem@davemloft.net CC: netdev@vger.kernel.org, tziporet@mellanox.co.il Subject: [PATCH 6/6] mlx4_en: use NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM for tx csum at initialization X-OriginalArrivalTime: 26 Mar 2009 14:00:49.0422 (UTC) FILETIME=[448D22E0:01C9AE1B] X-TM-AS-Product-Ver: SMEX-8.0.0.1181-5.600.1016-16542.007 X-TM-AS-Result: No-2.540900-8.000000-31 X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The former usage was to set the NETIF_F_HW_CSUM flag which is not used in get_tx_csum. It caused Ethtool to show tx checksum as "on" even though it was turned off in previous operation. Signed-off-by: Yevgeny Petrilin --- drivers/net/mlx4/en_netdev.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/mlx4/en_netdev.c b/drivers/net/mlx4/en_netdev.c index f52e897..0909a0c 100644 --- a/drivers/net/mlx4/en_netdev.c +++ b/drivers/net/mlx4/en_netdev.c @@ -1056,7 +1056,7 @@ int mlx4_en_init_netdev(struct mlx4_en_dev *mdev, int port, * Set driver features */ dev->features |= NETIF_F_SG; - dev->features |= NETIF_F_HW_CSUM; + dev->features |= NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM; dev->features |= NETIF_F_HIGHDMA; dev->features |= NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX |