Patchwork ggc-page.c : remove erroneous ATTRIBUTE_UNUSED

login
register
mail settings
Submitter David Malcolm
Date June 14, 2013, 9:17 p.m.
Message ID <1371244664.4516.22.camel@surprise>
Download mbox | patch
Permalink /patch/251538/
State New
Headers show

Comments

David Malcolm - June 14, 2013, 9:17 p.m.
ggc_pch_write_object's parameter "d" is marked with ATTRIBUTE_UNUSED,
but in fact it is used in 4 places at the end of the function.

Successfully bootstrapped on x86_64-unknown-linux-gnu.

OK for trunk?

2013-06-14  David Malcolm  <dmalcolm@redhat.com>

	* ggc-page.c (ggc_pch_write_object) <d>: Remove erroneous
	ATTRIBUTE_UNUSED marking.
Richard Guenther - June 17, 2013, 9:18 a.m.
On Fri, Jun 14, 2013 at 11:17 PM, David Malcolm <dmalcolm@redhat.com> wrote:
> ggc_pch_write_object's parameter "d" is marked with ATTRIBUTE_UNUSED,
> but in fact it is used in 4 places at the end of the function.
>
> Successfully bootstrapped on x86_64-unknown-linux-gnu.
>
> OK for trunk?

Ok.

Thanks,
Richard.

> 2013-06-14  David Malcolm  <dmalcolm@redhat.com>
>
>         * ggc-page.c (ggc_pch_write_object) <d>: Remove erroneous
>         ATTRIBUTE_UNUSED marking.
>
>
David Malcolm - June 17, 2013, 5:26 p.m.
On Mon, 2013-06-17 at 11:18 +0200, Richard Biener wrote:
> On Fri, Jun 14, 2013 at 11:17 PM, David Malcolm <dmalcolm@redhat.com> wrote:
> > ggc_pch_write_object's parameter "d" is marked with ATTRIBUTE_UNUSED,
> > but in fact it is used in 4 places at the end of the function.
> >
> > Successfully bootstrapped on x86_64-unknown-linux-gnu.
> >
> > OK for trunk?
> 
> Ok.
Thanks; committed to svn trunk as r200154.

Patch

Index: gcc/ggc-page.c
===================================================================
--- gcc/ggc-page.c	(revision 200106)
+++ gcc/ggc-page.c	(working copy)
@@ -2291,7 +2291,7 @@ 
 }
 
 void
-ggc_pch_write_object (struct ggc_pch_data *d ATTRIBUTE_UNUSED,
+ggc_pch_write_object (struct ggc_pch_data *d,
 		      FILE *f, void *x, void *newx ATTRIBUTE_UNUSED,
 		      size_t size, bool is_string ATTRIBUTE_UNUSED)
 {