Patchwork [GIT,PULL,3/3] msm clock for 3.11

login
register
mail settings
Submitter David Brown
Date June 14, 2013, 7:52 p.m.
Message ID <20130614195238.GA2381@codeaurora.org>
Download mbox
Permalink /patch/251520/
State New
Headers show

Pull-request

git://git.kernel.org/pub/scm/linux/kernel/git/davidb/linux-msm.git tags/msm-clock-for-3.11

Comments

David Brown - June 14, 2013, 7:52 p.m.
The following changes since commit f722406faae2d073cc1d01063d1123c35425939e:

  Linux 3.10-rc1 (2013-05-11 17:14:08 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/davidb/linux-msm.git tags/msm-clock-for-3.11

for you to fetch changes up to f54c1c11053d8aaf318a096b8b332fd41a394a66:

  ARM: msm: Migrate to common clock framework (2013-06-12 14:43:31 -0700)

----------------------------------------------------------------
MSM clock updates for 3.11.

Per Stephen Boyd's coverletter:

This patchset moves the existing MSM clock code and affected drivers
to the common clock framework. A prerequisite of moving to the common
clock framework is to use clk_prepare() and clk_enable() so the first
few patches migrate drivers to that call (clk_prepare() is a no-op on
MSM right now). It also removes some custom clock APIs that MSM
provides and finally moves the proc_comm clock code to the common
struct clk.

This patch series will be used as the foundation of the MSM 8660/8960
clock code that I plan to send out after this series.

----------------------------------------------------------------
Stephen Boyd (12):
      msm_serial: Convert to clk_prepare/unprepare
      msm_serial: Use devm_clk_get() and properly return errors
      usb: otg: msm: Convert to clk_prepare/unprepare
      msm_sdcc: Convert to clk_prepare/unprepare
      msm: iommu: Convert to clk_prepare/unprepare
      msm: iommu: Use clk_set_rate() instead of clk_set_min_rate()
      ARM: msm: Remove custom clk_set_flags() API
      ARM: msm: Remove custom clk_set_{max,min}_rate() API
      ARM: msm: Remove clock-7x30.h include file
      ARM: msm: Prepare clk_get() users in mach-msm for clock-pcom driver
      ARM: msm: Make proc_comm clock control into a platform driver
      ARM: msm: Migrate to common clock framework

 arch/arm/Kconfig                       |   2 +-
 arch/arm/mach-msm/Makefile             |  10 +-
 arch/arm/mach-msm/board-halibut.c      |   2 +-
 arch/arm/mach-msm/board-msm7x30.c      |   2 +-
 arch/arm/mach-msm/board-qsd8x50.c      |   2 +-
 arch/arm/mach-msm/board-trout-panel.c  |  19 ++--
 arch/arm/mach-msm/board-trout.c        |   3 +-
 arch/arm/mach-msm/clock-7x30.h         | 155 ------------------------------
 arch/arm/mach-msm/clock-debug.c        | 130 --------------------------
 arch/arm/mach-msm/clock-pcom.c         | 149 ++++++++++++++++++-----------
 arch/arm/mach-msm/clock-pcom.h         |  31 +++---
 arch/arm/mach-msm/clock.c              | 166 +--------------------------------
 arch/arm/mach-msm/clock.h              |  51 +++-------
 arch/arm/mach-msm/devices-msm7x00.c    |  12 ++-
 arch/arm/mach-msm/devices-msm7x30.c    |  14 ++-
 arch/arm/mach-msm/devices-qsd8x50.c    |  11 ++-
 arch/arm/mach-msm/devices.h            |  15 +--
 arch/arm/mach-msm/dma.c                |   5 +-
 arch/arm/mach-msm/include/mach/board.h |   5 -
 arch/arm/mach-msm/include/mach/clk.h   |   9 --
 drivers/iommu/msm_iommu_dev.c          |  20 ++--
 drivers/mmc/host/msm_sdcc.c            |  14 ++-
 drivers/tty/serial/msm_serial.c        |  35 +++----
 drivers/usb/phy/phy-msm-usb.c          |  38 ++++----
 24 files changed, 241 insertions(+), 659 deletions(-)
 delete mode 100644 arch/arm/mach-msm/clock-7x30.h
 delete mode 100644 arch/arm/mach-msm/clock-debug.c
Olof Johansson - June 15, 2013, 1:35 a.m.
On Fri, Jun 14, 2013 at 12:52:55PM -0700, David Brown wrote:
> The following changes since commit f722406faae2d073cc1d01063d1123c35425939e:
> 
>  Linux 3.10-rc1 (2013-05-11 17:14:08 -0700)
> 
> are available in the git repository at:
> 
>  git://git.kernel.org/pub/scm/linux/kernel/git/davidb/linux-msm.git tags/msm-clock-for-3.11
> 
> for you to fetch changes up to f54c1c11053d8aaf318a096b8b332fd41a394a66:
> 
>  ARM: msm: Migrate to common clock framework (2013-06-12 14:43:31 -0700)
> 
> ----------------------------------------------------------------
> MSM clock updates for 3.11.
> 
> Per Stephen Boyd's coverletter:
> 
> This patchset moves the existing MSM clock code and affected drivers
> to the common clock framework. A prerequisite of moving to the common
> clock framework is to use clk_prepare() and clk_enable() so the first
> few patches migrate drivers to that call (clk_prepare() is a no-op on
> MSM right now). It also removes some custom clock APIs that MSM
> provides and finally moves the proc_comm clock code to the common
> struct clk.
> 
> This patch series will be used as the foundation of the MSM 8660/8960
> clock code that I plan to send out after this series.
> 
> ----------------------------------------------------------------
> Stephen Boyd (12):
>      msm_serial: Convert to clk_prepare/unprepare
>      msm_serial: Use devm_clk_get() and properly return errors
>      usb: otg: msm: Convert to clk_prepare/unprepare
>      msm_sdcc: Convert to clk_prepare/unprepare
>      msm: iommu: Convert to clk_prepare/unprepare
>      msm: iommu: Use clk_set_rate() instead of clk_set_min_rate()
>      ARM: msm: Remove custom clk_set_flags() API
>      ARM: msm: Remove custom clk_set_{max,min}_rate() API
>      ARM: msm: Remove clock-7x30.h include file
>      ARM: msm: Prepare clk_get() users in mach-msm for clock-pcom driver
>      ARM: msm: Make proc_comm clock control into a platform driver
>      ARM: msm: Migrate to common clock framework

I don't see a single ack from any of the driver subsystem maintainers for
serial, usb or iommu. Some of them have been acked though, for example Felipe
acked the USB one on the mailing list.

I also didn't see Greg cc:d on the serial patches, which would explain why
there was no ack for them.

Care to repost/collect/rebuild this branch, please? It's a great cleanup and
I'd be happy to take it even if it ends up coming in after -rc6.


-Olof
Olof Johansson - June 17, 2013, 5:35 p.m.
On Mon, Jun 17, 2013 at 10:18 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> On 06/14/13 18:35, Olof Johansson wrote:
>> On Fri, Jun 14, 2013 at 12:52:55PM -0700, David Brown wrote:
>>> The following changes since commit f722406faae2d073cc1d01063d1123c35425939e:
>>>
>>>  Linux 3.10-rc1 (2013-05-11 17:14:08 -0700)
>>>
>>> are available in the git repository at:
>>>
>>>  git://git.kernel.org/pub/scm/linux/kernel/git/davidb/linux-msm.git tags/msm-clock-for-3.11
>>>
>>> for you to fetch changes up to f54c1c11053d8aaf318a096b8b332fd41a394a66:
>>>
>>>  ARM: msm: Migrate to common clock framework (2013-06-12 14:43:31 -0700)
>>>
>>> ----------------------------------------------------------------
>>> MSM clock updates for 3.11.
>>>
>>> Per Stephen Boyd's coverletter:
>>>
>>> This patchset moves the existing MSM clock code and affected drivers
>>> to the common clock framework. A prerequisite of moving to the common
>>> clock framework is to use clk_prepare() and clk_enable() so the first
>>> few patches migrate drivers to that call (clk_prepare() is a no-op on
>>> MSM right now). It also removes some custom clock APIs that MSM
>>> provides and finally moves the proc_comm clock code to the common
>>> struct clk.
>>>
>>> This patch series will be used as the foundation of the MSM 8660/8960
>>> clock code that I plan to send out after this series.
>>>
>>> ----------------------------------------------------------------
>>> Stephen Boyd (12):
>>>      msm_serial: Convert to clk_prepare/unprepare
>>>      msm_serial: Use devm_clk_get() and properly return errors
>>>      usb: otg: msm: Convert to clk_prepare/unprepare
>>>      msm_sdcc: Convert to clk_prepare/unprepare
>>>      msm: iommu: Convert to clk_prepare/unprepare
>>>      msm: iommu: Use clk_set_rate() instead of clk_set_min_rate()
>>>      ARM: msm: Remove custom clk_set_flags() API
>>>      ARM: msm: Remove custom clk_set_{max,min}_rate() API
>>>      ARM: msm: Remove clock-7x30.h include file
>>>      ARM: msm: Prepare clk_get() users in mach-msm for clock-pcom driver
>>>      ARM: msm: Make proc_comm clock control into a platform driver
>>>      ARM: msm: Migrate to common clock framework
>> I don't see a single ack from any of the driver subsystem maintainers for
>> serial, usb or iommu. Some of them have been acked though, for example Felipe
>> acked the USB one on the mailing list.
>>
>> I also didn't see Greg cc:d on the serial patches, which would explain why
>> there was no ack for them.
>>
>> Care to repost/collect/rebuild this branch, please? It's a great cleanup and
>> I'd be happy to take it even if it ends up coming in after -rc6.
>
> MAINTAINERS shows the MSM maintainers for the serial and mmc drivers so
> I sent them to David. The iommu driver didn't seem to have any
> maintainers entry so I just sent it off to David as well.
>
> It wasn't clear to me that we needed to Cc higher level maintainers at
> all. Perhaps we should clarify this in SubmittingPatches?

get_maintainer is pretty clear on it, pointing out all maintainers up the chain.

This is normally not a problem when the maintainer sends code on up
the subsystem tree (i.e. to Greg in the case of serial patches). What
made me want an ack in this case is because the serial patches came in
for the arm-soc tree.


-Olof