Patchwork Fix documentation for x86 __builtin_ia32_cmp*s

login
register
mail settings
Submitter Cameron McInally
Date June 14, 2013, 5:41 p.m.
Message ID <CAKs25gPZTM5Pm1qtuO0P8HO+TydbCHN5Rj-wnsyfaY+uGnwrQA@mail.gmail.com>
Download mbox | patch
Permalink /patch/251475/
State New
Headers show

Comments

Cameron McInally - June 14, 2013, 5:41 p.m.
Hey guys,

The documentation states that the return types on the x86
__builtin_ia32_cmp*s builtins are integer vectors. This is
inconsistent with the source. These builtins actually return floating
point vectors. Here is a small patch to update the documentation.

-Cameron
Cameron McInally - July 17, 2013, 1:28 p.m.
Ping.

On Fri, Jun 14, 2013 at 1:41 PM, Cameron McInally
<cameron.mcinally@nyu.edu> wrote:
> Hey guys,
>
> The documentation states that the return types on the x86
> __builtin_ia32_cmp*s builtins are integer vectors. This is
> inconsistent with the source. These builtins actually return floating
> point vectors. Here is a small patch to update the documentation.
>
> -Cameron
Chung-Ju Wu - July 25, 2013, 2:28 p.m.
2013/7/17 Cameron McInally <cameron.mcinally@nyu.edu>:
> Ping.
>
> On Fri, Jun 14, 2013 at 1:41 PM, Cameron McInally
> <cameron.mcinally@nyu.edu> wrote:
>> Hey guys,
>>
>> The documentation states that the return types on the x86
>> __builtin_ia32_cmp*s builtins are integer vectors. This is
>> inconsistent with the source. These builtins actually return floating
>> point vectors. Here is a small patch to update the documentation.
>>
>> -Cameron

Let me help you cc x86 maintainer. :)
I also suggest you can also provide a ChangeLog entry.

Best regards,
jasonwucj
Cameron McInally - July 25, 2013, 4:56 p.m.
On Thu, Jul 25, 2013 at 10:28 AM, Chung-Ju Wu <jasonwucj@gmail.com> wrote:
> 2013/7/17 Cameron McInally <cameron.mcinally@nyu.edu>:
>> Ping.
>>
>> On Fri, Jun 14, 2013 at 1:41 PM, Cameron McInally
>> <cameron.mcinally@nyu.edu> wrote:
>>> Hey guys,
>>>
>>> The documentation states that the return types on the x86
>>> __builtin_ia32_cmp*s builtins are integer vectors. This is
>>> inconsistent with the source. These builtins actually return floating
>>> point vectors. Here is a small patch to update the documentation.
>>>
>>> -Cameron
>
> Let me help you cc x86 maintainer. :)
> I also suggest you can also provide a ChangeLog entry.
>
> Best regards,
> jasonwucj

Thanks, Jason and Uros. Here is a proposed ChangeLog entry. Just
FYI... this is new to me, so perhaps I am missing something. I have
also re-attached the patch for your convenience.

2013-07-25  Cameron McInally  <cameron.mcinally@nyu.edu>

        * doc/extend.texi: Fix return types for __builtin_ia32_cmp*s
          builtins.

-Cameron

Patch

Index: doc/extend.texi
===================================================================
--- doc/extend.texi	(revision 200083)
+++ doc/extend.texi	(working copy)
@@ -9948,26 +9948,26 @@ 
 v4sf __builtin_ia32_subss (v4sf, v4sf)
 v4sf __builtin_ia32_mulss (v4sf, v4sf)
 v4sf __builtin_ia32_divss (v4sf, v4sf)
-v4si __builtin_ia32_cmpeqps (v4sf, v4sf)
-v4si __builtin_ia32_cmpltps (v4sf, v4sf)
-v4si __builtin_ia32_cmpleps (v4sf, v4sf)
-v4si __builtin_ia32_cmpgtps (v4sf, v4sf)
-v4si __builtin_ia32_cmpgeps (v4sf, v4sf)
-v4si __builtin_ia32_cmpunordps (v4sf, v4sf)
-v4si __builtin_ia32_cmpneqps (v4sf, v4sf)
-v4si __builtin_ia32_cmpnltps (v4sf, v4sf)
-v4si __builtin_ia32_cmpnleps (v4sf, v4sf)
-v4si __builtin_ia32_cmpngtps (v4sf, v4sf)
-v4si __builtin_ia32_cmpngeps (v4sf, v4sf)
-v4si __builtin_ia32_cmpordps (v4sf, v4sf)
-v4si __builtin_ia32_cmpeqss (v4sf, v4sf)
-v4si __builtin_ia32_cmpltss (v4sf, v4sf)
-v4si __builtin_ia32_cmpless (v4sf, v4sf)
-v4si __builtin_ia32_cmpunordss (v4sf, v4sf)
-v4si __builtin_ia32_cmpneqss (v4sf, v4sf)
-v4si __builtin_ia32_cmpnlts (v4sf, v4sf)
-v4si __builtin_ia32_cmpnless (v4sf, v4sf)
-v4si __builtin_ia32_cmpordss (v4sf, v4sf)
+v4sf __builtin_ia32_cmpeqps (v4sf, v4sf)
+v4sf __builtin_ia32_cmpltps (v4sf, v4sf)
+v4sf __builtin_ia32_cmpleps (v4sf, v4sf)
+v4sf __builtin_ia32_cmpgtps (v4sf, v4sf)
+v4sf __builtin_ia32_cmpgeps (v4sf, v4sf)
+v4sf __builtin_ia32_cmpunordps (v4sf, v4sf)
+v4sf __builtin_ia32_cmpneqps (v4sf, v4sf)
+v4sf __builtin_ia32_cmpnltps (v4sf, v4sf)
+v4sf __builtin_ia32_cmpnleps (v4sf, v4sf)
+v4sf __builtin_ia32_cmpngtps (v4sf, v4sf)
+v4sf __builtin_ia32_cmpngeps (v4sf, v4sf)
+v4sf __builtin_ia32_cmpordps (v4sf, v4sf)
+v4sf __builtin_ia32_cmpeqss (v4sf, v4sf)
+v4sf __builtin_ia32_cmpltss (v4sf, v4sf)
+v4sf __builtin_ia32_cmpless (v4sf, v4sf)
+v4sf __builtin_ia32_cmpunordss (v4sf, v4sf)
+v4sf __builtin_ia32_cmpneqss (v4sf, v4sf)
+v4sf __builtin_ia32_cmpnlts (v4sf, v4sf)
+v4sf __builtin_ia32_cmpnless (v4sf, v4sf)
+v4sf __builtin_ia32_cmpordss (v4sf, v4sf)
 v4sf __builtin_ia32_maxps (v4sf, v4sf)
 v4sf __builtin_ia32_maxss (v4sf, v4sf)
 v4sf __builtin_ia32_minps (v4sf, v4sf)