Patchwork [U-Boot,2/2] video: lcd: Make splash_screen_prepare weak, remove config macro

login
register
mail settings
Submitter Robert Winkler
Date June 14, 2013, 5 p.m.
Message ID <1371229203-10840-3-git-send-email-robert.winkler@boundarydevices.com>
Download mbox | patch
Permalink /patch/251472/
State Superseded
Delegated to: Anatolij Gustschin
Headers show

Comments

Robert Winkler - June 14, 2013, 5 p.m.
Remove CONFIG_SPLASH_SCREEN_PREPARE from README
Add doc/README.splashprepare to document functionality

Signed-off-by: Robert Winkler <robert.winkler@boundarydevices.com>
---
 README                   |  8 --------
 common/splash.c          | 14 ++++----------
 doc/README.splashprepare |  8 ++++++++
 3 files changed, 12 insertions(+), 18 deletions(-)
 create mode 100644 doc/README.splashprepare

Patch

diff --git a/README b/README
index 0d37d56..fd3d3a5 100644
--- a/README
+++ b/README
@@ -1604,14 +1604,6 @@  CBFS (Coreboot Filesystem) support
 			=> vertically centered image
 			   at x = dspWidth - bmpWidth - 9
 
-		CONFIG_SPLASH_SCREEN_PREPARE
-
-		If this option is set then the board_splash_screen_prepare()
-		function, which must be defined in your code, is called as part
-		of the splash screen display sequence. It gives the board an
-		opportunity to prepare the splash image data before it is
-		processed and sent to the frame buffer by U-Boot.
-
 - Gzip compressed BMP image support: CONFIG_VIDEO_BMP_GZIP
 
 		If this option is set, additionally to standard BMP
diff --git a/common/splash.c b/common/splash.c
index fe13c69..c40861a 100644
--- a/common/splash.c
+++ b/common/splash.c
@@ -21,17 +21,11 @@ 
  */
 
 #include <splash.h>
-#include <config.h>
 
-#ifdef CONFIG_SPLASH_SCREEN_PREPARE
-int splash_screen_prepare(void)
-{
-	return board_splash_screen_prepare();
-}
-#else
-int splash_screen_prepare(void)
+int __splash_screen_prepare(void)
 {
-	printf("SPLASH_SCREEN_PREPARE not defined\n");
 	return 0;
 }
-#endif
+
+int splash_screen_prepare(void)
+	__attribute__ ((weak, alias("__splash_screen_prepare")));
diff --git a/doc/README.splashprepare b/doc/README.splashprepare
new file mode 100644
index 0000000..8d103bf
--- /dev/null
+++ b/doc/README.splashprepare
@@ -0,0 +1,8 @@ 
+---------------------------------------------------------------------
+Splash Screen
+---------------------------------------------------------------------
+The splash_screen_prepare() function is a weak function defined in
+common/splash.c. It is called as part of the splash screen display
+sequence. It gives the board an opportunity to prepare the splash
+image data before it is processed and sent to the frame buffer by
+U-Boot.  Define your own version to use this feature.