Patchwork [v3,02/16] qemu-option: check_params() is now unused, drop it

login
register
mail settings
Submitter Markus Armbruster
Date June 14, 2013, 11:15 a.m.
Message ID <1371208516-7857-3-git-send-email-armbru@redhat.com>
Download mbox | patch
Permalink /patch/251361/
State New
Headers show

Comments

Markus Armbruster - June 14, 2013, 11:15 a.m.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 include/qemu/option.h |  2 --
 util/qemu-option.c    | 30 ------------------------------
 2 files changed, 32 deletions(-)
Anthony Liguori - June 14, 2013, 1:36 p.m.
Markus Armbruster <armbru@redhat.com> writes:

> Signed-off-by: Markus Armbruster <armbru@redhat.com>

Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>

Regards,

Anthony Liguori

> ---
>  include/qemu/option.h |  2 --
>  util/qemu-option.c    | 30 ------------------------------
>  2 files changed, 32 deletions(-)
>
> diff --git a/include/qemu/option.h b/include/qemu/option.h
> index bdb6d21..a83c700 100644
> --- a/include/qemu/option.h
> +++ b/include/qemu/option.h
> @@ -55,8 +55,6 @@ int get_next_param_value(char *buf, int buf_size,
>                           const char *tag, const char **pstr);
>  int get_param_value(char *buf, int buf_size,
>                      const char *tag, const char *str);
> -int check_params(char *buf, int buf_size,
> -                 const char * const *params, const char *str);
>  
>  
>  /*
> diff --git a/util/qemu-option.c b/util/qemu-option.c
> index 8b74bf1..412c425 100644
> --- a/util/qemu-option.c
> +++ b/util/qemu-option.c
> @@ -123,36 +123,6 @@ int get_param_value(char *buf, int buf_size,
>      return get_next_param_value(buf, buf_size, tag, &str);
>  }
>  
> -int check_params(char *buf, int buf_size,
> -                 const char * const *params, const char *str)
> -{
> -    const char *p;
> -    int i;
> -
> -    p = str;
> -    while (*p != '\0') {
> -        p = get_opt_name(buf, buf_size, p, '=');
> -        if (*p != '=') {
> -            return -1;
> -        }
> -        p++;
> -        for (i = 0; params[i] != NULL; i++) {
> -            if (!strcmp(params[i], buf)) {
> -                break;
> -            }
> -        }
> -        if (params[i] == NULL) {
> -            return -1;
> -        }
> -        p = get_opt_value(NULL, 0, p);
> -        if (*p != ',') {
> -            break;
> -        }
> -        p++;
> -    }
> -    return 0;
> -}
> -
>  /*
>   * Searches an option list for an option with the given name
>   */
> -- 
> 1.7.11.7

Patch

diff --git a/include/qemu/option.h b/include/qemu/option.h
index bdb6d21..a83c700 100644
--- a/include/qemu/option.h
+++ b/include/qemu/option.h
@@ -55,8 +55,6 @@  int get_next_param_value(char *buf, int buf_size,
                          const char *tag, const char **pstr);
 int get_param_value(char *buf, int buf_size,
                     const char *tag, const char *str);
-int check_params(char *buf, int buf_size,
-                 const char * const *params, const char *str);
 
 
 /*
diff --git a/util/qemu-option.c b/util/qemu-option.c
index 8b74bf1..412c425 100644
--- a/util/qemu-option.c
+++ b/util/qemu-option.c
@@ -123,36 +123,6 @@  int get_param_value(char *buf, int buf_size,
     return get_next_param_value(buf, buf_size, tag, &str);
 }
 
-int check_params(char *buf, int buf_size,
-                 const char * const *params, const char *str)
-{
-    const char *p;
-    int i;
-
-    p = str;
-    while (*p != '\0') {
-        p = get_opt_name(buf, buf_size, p, '=');
-        if (*p != '=') {
-            return -1;
-        }
-        p++;
-        for (i = 0; params[i] != NULL; i++) {
-            if (!strcmp(params[i], buf)) {
-                break;
-            }
-        }
-        if (params[i] == NULL) {
-            return -1;
-        }
-        p = get_opt_value(NULL, 0, p);
-        if (*p != ',') {
-            break;
-        }
-        p++;
-    }
-    return 0;
-}
-
 /*
  * Searches an option list for an option with the given name
  */