From patchwork Fri Jun 14 02:31:39 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Stump X-Patchwork-Id: 251206 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "localhost", Issuer "www.qmailtoaster.com" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 1CD892C016F for ; Fri, 14 Jun 2013 12:31:57 +1000 (EST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :content-type:content-transfer-encoding:subject:message-id:date :to:mime-version; q=dns; s=default; b=HWQxll4RoREE8AHnUebjelvImq h0A9JCT4sGcsWCqQ0ysDtmUeOfclQBMsrDAGPHZ/2snd2KZ/3RbtHsBl7XUHGZg8 BXcC+X/mpTK9PdPrMM0DxsatF1yjXFTjhfl1wOB0L35n3wwBPnvh32qFrbCWIg2a +XNdQmOV3pRhWI4W8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:from :content-type:content-transfer-encoding:subject:message-id:date :to:mime-version; s=default; bh=TX89cssIMmt06s9SXBoMUPFl6Hc=; b= fqxW8xfSvdW0pmfasohHT/VvbuMD9TEM94A5j97Vre3eVzy/seGLMpMHhqx6y2Qm zOkg0+HUcnVfvPUKxFtYW1YaIF74UHrhKWA9IHICqFYBqD29RItfmLAk2kEGCH5G 5p45tGUXPnm/vtQtEP+DVPjYpy7nU42xeLqvRAP9Nzo= Received: (qmail 6719 invoked by alias); 14 Jun 2013 02:31:50 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 6678 invoked by uid 89); 14 Jun 2013 02:31:44 -0000 X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RCVD_IN_HOSTKARMA_NO, RCVD_IN_HOSTKARMA_YE, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.1 Received: from qmta13.emeryville.ca.mail.comcast.net (HELO qmta13.emeryville.ca.mail.comcast.net) (76.96.27.243) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 14 Jun 2013 02:31:43 +0000 Received: from omta03.emeryville.ca.mail.comcast.net ([76.96.30.27]) by qmta13.emeryville.ca.mail.comcast.net with comcast id o2HC1l0010b6N64AD2XiaJ; Fri, 14 Jun 2013 02:31:42 +0000 Received: from bag6-1-pt.tunnel.tserv3.fmt2.ipv6.he.net ([IPv6:2001:470:1f04:ae1::2]) by omta03.emeryville.ca.mail.comcast.net with comcast id o2Xg1l00G0P3DwE8P2XhNK; Fri, 14 Jun 2013 02:31:41 +0000 From: Mike Stump Subject: target.h uses insn-codes.h Message-Id: <45B2E882-279A-495A-8493-ACCD657CDEDB@comcast.net> Date: Thu, 13 Jun 2013 19:31:39 -0700 To: gcc-patches patches Mime-Version: 1.0 (Mac OS X Mail 6.3 \(1503\)) When doing a -j16 build of top of the trunk from a little while ago, with our wide-int patches in it, I hit: g++ -c -g -DIN_GCC -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings -fno-common -DHAVE_CONFIG_H -I. -Ilto -I../../gcc/gcc -I../../gcc/gcc/lto -I../../gcc/gcc/../include -I../../gcc/gcc/../libcpp/include -I../../gcc/gcc/../libdecnumber -I../../gcc/gcc/../libdecnumber/bid -I../libdecnumber -I../../gcc/gcc/../libbacktrace ../../gcc/gcc/lto/lto-partition.c -o lto/lto-partition.o In file included from ../../gcc/gcc/lto-streamer.h:30:0, from ../../gcc/gcc/lto/lto-object.c:27: ../../gcc/gcc/target.h:52:24: fatal error: insn-codes.h: No such file or directory compilation terminated. make[3]: *** [lto/lto-object.o] Error 1 make[3]: *** Waiting for unfinished jobs.... In file included from ../../gcc/gcc/lto-streamer.h:30:0, from ../../gcc/gcc/lto/lto-partition.c:27: ../../gcc/gcc/target.h:52:24: fatal error: insn-codes.h: No such file or directory compilation terminated. make[3]: *** [lto/lto-partition.o] Error 1 to my untrained eye, it seems we are missing: I think insn-codes.h falls in to the same or easier class (no stamp file for it) than insn-modes.h, so, I think this is ok; but would be nice to have someone review it. I checked trunk, and I don't see any thing that would ensure insn-codes.h is done before target.h is used. Ok? diff --git a/gcc/Makefile.in b/gcc/Makefile.in index a098040..a9f4dee 100644 --- a/gcc/Makefile.in +++ b/gcc/Makefile.in @@ -841,7 +841,7 @@ EXCEPT_H = except.h $(HASHTAB_H) TARGET_DEF = target.def target-hooks-macros.h C_TARGET_DEF = c-family/c-target.def target-hooks-macros.h COMMON_TARGET_DEF = common/common-target.def target-hooks-macros.h -TARGET_H = $(TM_H) target.h $(TARGET_DEF) insn-modes.h +TARGET_H = $(TM_H) target.h $(TARGET_DEF) insn-modes.h insn-codes.h C_TARGET_H = c-family/c-target.h $(C_TARGET_DEF) COMMON_TARGET_H = common/common-target.h $(INPUT_H) $(COMMON_TARGET_DEF) MACHMODE_H = machmode.h mode-classes.def insn-modes.h