From patchwork Fri Jun 14 02:06:47 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gao feng X-Patchwork-Id: 251205 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id DF1032C02A8 for ; Fri, 14 Jun 2013 12:05:48 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759509Ab3FNCFQ (ORCPT ); Thu, 13 Jun 2013 22:05:16 -0400 Received: from cn.fujitsu.com ([222.73.24.84]:55822 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1750970Ab3FNCFO (ORCPT ); Thu, 13 Jun 2013 22:05:14 -0400 X-IronPort-AV: E=Sophos;i="4.87,863,1363104000"; d="scan'208";a="7542304" Received: from unknown (HELO tang.cn.fujitsu.com) ([10.167.250.3]) by song.cn.fujitsu.com with ESMTP; 14 Jun 2013 10:02:18 +0800 Received: from fnstmail02.fnst.cn.fujitsu.com (tang.cn.fujitsu.com [127.0.0.1]) by tang.cn.fujitsu.com (8.14.3/8.13.1) with ESMTP id r5E25A3G006673; Fri, 14 Jun 2013 10:05:10 +0800 Received: from Donkey-I5.fnst.cn.fujitsu.com ([10.167.233.32]) by fnstmail02.fnst.cn.fujitsu.com (Lotus Domino Release 8.5.3) with ESMTP id 2013061410031502-2116474 ; Fri, 14 Jun 2013 10:03:15 +0800 From: Gao feng To: davem@davemloft.net Cc: ebiederm@xmission.com, netdev@vger.kernel.org, Gao feng Subject: [PATCH v2 4/4] neigh: don't leak default parms to uninitial netns Date: Fri, 14 Jun 2013 10:06:47 +0800 Message-Id: <1371175607-1405-4-git-send-email-gaofeng@cn.fujitsu.com> X-Mailer: git-send-email 1.8.1.4 In-Reply-To: <1371175607-1405-1-git-send-email-gaofeng@cn.fujitsu.com> References: <1371175607-1405-1-git-send-email-gaofeng@cn.fujitsu.com> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/06/14 10:03:15, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2013/06/14 10:03:16, Serialize complete at 2013/06/14 10:03:16 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Only allow initial net namespace to get default parms through netlink. Signed-off-by: Gao feng --- net/core/neighbour.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/core/neighbour.c b/net/core/neighbour.c index 5e0fe89..3bb6115 100644 --- a/net/core/neighbour.c +++ b/net/core/neighbour.c @@ -2094,7 +2094,8 @@ static int neightbl_dump_info(struct sk_buff *skb, struct netlink_callback *cb) if (tidx < tbl_skip || (family && tbl->family != family)) continue; - if (neightbl_fill_info(skb, tbl, NETLINK_CB(cb->skb).portid, + if (net_eq(net, &init_net) && + neightbl_fill_info(skb, tbl, NETLINK_CB(cb->skb).portid, cb->nlh->nlmsg_seq, RTM_NEWNEIGHTBL, NLM_F_MULTI) <= 0) break;