From patchwork Thu Jun 13 13:31:58 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Prins Anton (ST-CO/ENG1.1)" X-Patchwork-Id: 251076 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:770:15f::2]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 929B22C0095 for ; Thu, 13 Jun 2013 23:32:44 +1000 (EST) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Un7dm-0000NV-1e; Thu, 13 Jun 2013 13:32:38 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Un7dj-0004pn-Su; Thu, 13 Jun 2013 13:32:35 +0000 Received: from smtp6-v.fe.bosch.de ([2a03:cc00:ff0:100::2]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Un7dg-0004ot-Ri for linux-mtd@lists.infradead.org; Thu, 13 Jun 2013 13:32:34 +0000 Received: from vsmta14.fe.internet.bosch.com (unknown [10.4.98.54]) by imta24.fe.bosch.de (Postfix) with ESMTP id A9A5FD80141; Thu, 13 Jun 2013 15:32:07 +0200 (CEST) Received: from localhost (vsgw3.fe.internet.bosch.com [10.4.98.16]) by vsmta14.fe.internet.bosch.com (Postfix) with SMTP id 9C73CA40C69; Thu, 13 Jun 2013 15:31:27 +0200 (CEST) Received: from SI-MBX14.de.bosch.com ([10.3.153.78]) by si-hub04.de.bosch.com ([10.3.153.46]) with mapi; Thu, 13 Jun 2013 15:32:00 +0200 From: "Prins Anton (ST-CO/ENG1.1)" To: =?iso-8859-1?Q?Mats_K=E4rrman?= , Adrian Hunter Date: Thu, 13 Jun 2013 15:31:58 +0200 Subject: RE: UBIFS failure & stable page writes Thread-Topic: UBIFS failure & stable page writes Thread-Index: Ac5a1m5eLmAuig9HRsKibAW1mwo+YAABBNZQABjxWwAACLtTgAABScMAAAEwu4AAAdm1AAAERZmAACkRNwAAavINgACO1mgAAZ9yDwAAKUNJgAAGzTMAAAGmmQD///9PAIAAFA6AgAANV4CAAYAqnv//1VzA Message-ID: <85D877DD6EE67B4A9FCA9B9C3A4865670C3F1A3C5D@SI-MBX14.de.bosch.com> References: <85D877DD6EE67B4A9FCA9B9C3A4865670C3E8CB9B7@SI-MBX14.de.bosch.com> <20130527121828.GA32625@quack.suse.cz> <85D877DD6EE67B4A9FCA9B9C3A4865670C3E8CBB8D@SI-MBX14.de.bosch.com> <1369709828.5446.89.camel@sauron.fi.intel.com> <85D877DD6EE67B4A9FCA9B9C3A4865670C3E8CBD81@SI-MBX14.de.bosch.com> <1369727042.5446.112.camel@sauron.fi.intel.com> <85D877DD6EE67B4A9FCA9B9C3A4865670C3E8CBE33@SI-MBX14.de.bosch.com> <1369732266.5446.117.camel@sauron.fi.intel.com> <85D877DD6EE67B4A9FCA9B9C3A4865670C3E91DC9C@SI-MBX14.de.bosch.com> <1369810158.5446.208.camel@sauron.fi.intel.com> <85D877DD6EE67B4A9FCA9B9C3A4865670C3E91E697@SI-MBX14.de.bosch.com> <1370239282.21714.21.camel@sauron.fi.intel.com> <85D877DD6EE67B4A9FCA9B9C3A4865670C3EA0F38E@SI-MBX14.de.bosch.com> <51B82A1D.30009@intel.com> <85D877DD6EE67B4A9FCA9B9C3A4865670C3F1A3508@SI-MBX14.de.bosch.com> <51B862D6.2080807@intel.com> <85D877DD6EE67B4A9FCA9B9C3A4865670C3F1A3590@SI-MBX14.de.bosch.com> <51B87315.7090808@intel.com>, <85D877DD6EE67B4A9FCA9B9C3A4865670C3F1A36BC@SI-MBX14.de.bosch.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130613_093233_285109_19ECF4C6 X-CRM114-Status: UNSURE ( 5.38 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: "linux-mtd@lists.infradead.org" , "dedekind1@gmail.com" X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org We decided not to patch for this weekend, but onlty make an additional logging in UBIFS: This to make sure if UBIFS itself writes a node '0' or '1'... and it is forced by UBI, NAND, Peripheral or NAND-Device. If there is a relation between logging and failing after reboot it would make sense... Means a lot of analyzing; but we have to find it! Next step is to apply patches and to test again: http://git.infradead.org/ubifs-2.6.git/commit/8afd500cb52a5d00bab4525dd5a560d199f979b9 http://git.infradead.org/ubifs-2.6.git/commit/2928f0d0c5ebd6c9605c0d98207a44376387c298 And hopefully we get rid of some unexpected orphan nodes. How realistic is it that the double orphan free causes our problem? Mats, are you sure the patches mentioned above are also not in your UBIFS? diff -purN a/fs/ubifs/orphan.c b/fs/ubifs/orphan.c --- a/fs/ubifs/orphan.c 2013-06-13 12:19:58.490931170 +0200 +++ b/fs/ubifs/orphan.c 2013-06-13 12:17:13.014931462 +0200 @@ -300,6 +300,9 @@ static int write_orph_node(struct ubifs_ for (i = 0; i < cnt; i++) { orphan = cnext; orph->inos[i] = cpu_to_le64(orphan->inum); + if (orph->inos[i] < UBIFS_FIRST_INO) { + printk(KERN_ERR "ERROR: Wrong ino in orphan list[%lu]: %lu\n", (unsigned long)i, (unsigned long)orph->inos[i]); + } cnext = orphan->cnext; orphan->cnext = NULL; }