Message ID | 1371111702.24768.7.camel@phoenix |
---|---|
State | Accepted |
Delegated to: | Jagannadha Sutradharudu Teki |
Headers | show |
Dear Axel Lin, > It's done in spi_alloc_slave(), thus remove the redundant code. > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > --- > drivers/spi/tegra20_sflash.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/spi/tegra20_sflash.c b/drivers/spi/tegra20_sflash.c > index 9322ce7..7c3a3fc 100644 > --- a/drivers/spi/tegra20_sflash.c > +++ b/drivers/spi/tegra20_sflash.c > @@ -132,8 +132,6 @@ struct spi_slave *tegra20_spi_setup_slave(unsigned int > bus, unsigned int cs, printf("SPI error: malloc of SPI structure > failed\n"); > return NULL; > } > - spi->slave.bus = bus; > - spi->slave.cs = cs; > spi->ctrl = &spi_ctrls[bus]; > if (!spi->ctrl) { > printf("SPI error: could not find controller for bus %d\n", Acked-by: Marek Vasut <marex@denx.de> Best regards, Marek Vasut
On 13-06-2013 16:18, Marek Vasut wrote: > Dear Axel Lin, > >> It's done in spi_alloc_slave(), thus remove the redundant code. >> >> Signed-off-by: Axel Lin <axel.lin@ingics.com> >> --- >> drivers/spi/tegra20_sflash.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/drivers/spi/tegra20_sflash.c b/drivers/spi/tegra20_sflash.c >> index 9322ce7..7c3a3fc 100644 >> --- a/drivers/spi/tegra20_sflash.c >> +++ b/drivers/spi/tegra20_sflash.c >> @@ -132,8 +132,6 @@ struct spi_slave *tegra20_spi_setup_slave(unsigned int >> bus, unsigned int cs, printf("SPI error: malloc of SPI structure >> failed\n"); >> return NULL; >> } >> - spi->slave.bus = bus; >> - spi->slave.cs = cs; >> spi->ctrl = &spi_ctrls[bus]; >> if (!spi->ctrl) { >> printf("SPI error: could not find controller for bus %d\n", > > Acked-by: Marek Vasut <marex@denx.de> > > Best regards, > Marek Vasut > Reviewed-by: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com> -- Thanks, Jagan.
On 13-06-2013 13:51, Axel Lin wrote: > It's done in spi_alloc_slave(), thus remove the redundant code. > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > Acked-by: Marek Vasut <marex@denx.de> > Reviewed-by: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com> > > --- > drivers/spi/tegra20_sflash.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/spi/tegra20_sflash.c b/drivers/spi/tegra20_sflash.c > index 9322ce7..7c3a3fc 100644 > --- a/drivers/spi/tegra20_sflash.c > +++ b/drivers/spi/tegra20_sflash.c > @@ -132,8 +132,6 @@ struct spi_slave *tegra20_spi_setup_slave(unsigned int bus, unsigned int cs, > printf("SPI error: malloc of SPI structure failed\n"); > return NULL; > } > - spi->slave.bus = bus; > - spi->slave.cs = cs; > spi->ctrl = &spi_ctrls[bus]; > if (!spi->ctrl) { > printf("SPI error: could not find controller for bus %d\n", > Applied to u-boot-spi/master -- Thanks, Jagan.
diff --git a/drivers/spi/tegra20_sflash.c b/drivers/spi/tegra20_sflash.c index 9322ce7..7c3a3fc 100644 --- a/drivers/spi/tegra20_sflash.c +++ b/drivers/spi/tegra20_sflash.c @@ -132,8 +132,6 @@ struct spi_slave *tegra20_spi_setup_slave(unsigned int bus, unsigned int cs, printf("SPI error: malloc of SPI structure failed\n"); return NULL; } - spi->slave.bus = bus; - spi->slave.cs = cs; spi->ctrl = &spi_ctrls[bus]; if (!spi->ctrl) { printf("SPI error: could not find controller for bus %d\n",
It's done in spi_alloc_slave(), thus remove the redundant code. Signed-off-by: Axel Lin <axel.lin@ingics.com> --- drivers/spi/tegra20_sflash.c | 2 -- 1 file changed, 2 deletions(-)