From patchwork Thu Jun 13 07:02:12 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Armbruster X-Patchwork-Id: 250997 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 9C5252C008A for ; Thu, 13 Jun 2013 17:33:30 +1000 (EST) Received: from localhost ([::1]:40604 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Un1aU-0005wa-5L for incoming@patchwork.ozlabs.org; Thu, 13 Jun 2013 03:04:50 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Un1Y8-0002xB-S2 for qemu-devel@nongnu.org; Thu, 13 Jun 2013 03:02:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Un1Y7-000327-Mj for qemu-devel@nongnu.org; Thu, 13 Jun 2013 03:02:24 -0400 Received: from oxygen.pond.sub.org ([2a01:4f8:121:10e4::3]:39439) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Un1Y7-00031d-GF for qemu-devel@nongnu.org; Thu, 13 Jun 2013 03:02:23 -0400 Received: from blackfin.pond.sub.org (p5B32AA2B.dip0.t-ipconnect.de [91.50.170.43]) by oxygen.pond.sub.org (Postfix) with ESMTPA id 092D19FE55; Thu, 13 Jun 2013 09:02:19 +0200 (CEST) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 47FFC200B3; Thu, 13 Jun 2013 09:02:19 +0200 (CEST) From: Markus Armbruster To: qemu-devel@nongnu.org Date: Thu, 13 Jun 2013 09:02:12 +0200 Message-Id: <1371106939-6968-2-git-send-email-armbru@redhat.com> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1371106939-6968-1-git-send-email-armbru@redhat.com> References: <1371106939-6968-1-git-send-email-armbru@redhat.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a01:4f8:121:10e4::3 Cc: mtosatti@redhat.com, borntraeger@de.ibm.com, pbonzini@redhat.com, agraf@suse.de, stefano.stabellini@eu.citrix.com Subject: [Qemu-devel] [PATCH RFC 1/8] exec: Fix Xen RAM allocation with unusual options X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Issues: * We try to obey -mem-path even though it can't work with Xen. * To implement -machine mem-merge, we call memory_try_enable_merging(new_block->host, size). But with Xen, new_block->host remains null. Oops. Fix by separating Xen allocation from normal allocation. Signed-off-by: Markus Armbruster Acked-by: Stefano Stabellini --- exec.c | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/exec.c b/exec.c index 5b8b40d..b424e12 100644 --- a/exec.c +++ b/exec.c @@ -1081,6 +1081,12 @@ ram_addr_t qemu_ram_alloc_from_ptr(ram_addr_t size, void *host, if (host) { new_block->host = host; new_block->flags |= RAM_PREALLOC_MASK; + } else if (xen_enabled()) { + if (mem_path) { + fprintf(stderr, "-mem-path not supported with Xen\n"); + exit(1); + } + xen_ram_alloc(new_block->offset, size, mr); } else { if (mem_path) { #if defined (__linux__) && !defined(TARGET_S390X) @@ -1094,9 +1100,7 @@ ram_addr_t qemu_ram_alloc_from_ptr(ram_addr_t size, void *host, exit(1); #endif } else { - if (xen_enabled()) { - xen_ram_alloc(new_block->offset, size, mr); - } else if (kvm_enabled()) { + if (kvm_enabled()) { /* some s390/kvm configurations have special constraints */ new_block->host = kvm_ram_alloc(size); } else { @@ -1174,6 +1178,8 @@ void qemu_ram_free(ram_addr_t addr) ram_list.version++; if (block->flags & RAM_PREALLOC_MASK) { ; + } else if (xen_enabled()) { + xen_invalidate_map_cache_entry(block->host); } else if (mem_path) { #if defined (__linux__) && !defined(TARGET_S390X) if (block->fd) { @@ -1186,11 +1192,7 @@ void qemu_ram_free(ram_addr_t addr) abort(); #endif } else { - if (xen_enabled()) { - xen_invalidate_map_cache_entry(block->host); - } else { - qemu_anon_ram_free(block->host, block->length); - } + qemu_anon_ram_free(block->host, block->length); } g_free(block); break; @@ -1214,6 +1216,8 @@ void qemu_ram_remap(ram_addr_t addr, ram_addr_t length) vaddr = block->host + offset; if (block->flags & RAM_PREALLOC_MASK) { ; + } else if (xen_enabled()) { + abort(); } else { flags = MAP_FIXED; munmap(vaddr, length);