Patchwork [U-Boot] wandboard: Fix typo in README

login
register
mail settings
Submitter Shigeru Yoshida
Date June 13, 2013, 3:29 a.m.
Message ID <CAMQoM_0gL2cZu_Xm-C9_ZONmGmYi1M6W_ysxUv2ETaEbuVRKOg@mail.gmail.com>
Download mbox | patch
Permalink /patch/250975/
State Rejected
Delegated to: Stefano Babic
Headers show

Comments

Shigeru Yoshida - June 13, 2013, 3:29 a.m.
Fix configuration make target to use uppercase letters.

Signed-off-by: Shigeru Yoshida <shigeru.yoshida@miraclelinux.com>
---
 board/wandboard/README |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Wolfgang Denk - June 13, 2013, 4:28 a.m.
Dear Shigeru Yoshida,

In message <CAMQoM_0gL2cZu_Xm-C9_ZONmGmYi1M6W_ysxUv2ETaEbuVRKOg@mail.gmail.com> you wrote:
>
> diff --git a/board/wandboard/README b/board/wandboard/README
> index e0b0b33..8bf646d 100644
> --- a/board/wandboard/README
> +++ b/board/wandboard/README
> @@ -14,12 +14,12 @@ Building U-boot for Wandboard
> 
>  To build U-Boot for the Wandboard Dual Lite version:
> 
> -$ make wanboard_dl_config
> +$ make WANBOARD_DL_config
>  $ make
> 
>  To build U-Boot for the Wandboard Solo version:
> 
> -$ make wanboard_solo_config
> +$ make WANBOARD_SOLO_config
>  $ make

Both "fixes" are wrong.  First, the target names are _really lower
case.  Second, the name is wan>d<board, i. e. you still have the 'd'
missing.  Please change into:

	$ make wandboard_dl_config
resp.
	$ make wandboard_solo_config


Best regards,

Wolfgang Denk
Otavio Salvador - June 13, 2013, 11:40 a.m.
On Thu, Jun 13, 2013 at 1:28 AM, Wolfgang Denk <wd@denx.de> wrote:

> Dear Shigeru Yoshida,
>
> In message <
> CAMQoM_0gL2cZu_Xm-C9_ZONmGmYi1M6W_ysxUv2ETaEbuVRKOg@mail.gmail.com> you
> wrote:
> >
> > diff --git a/board/wandboard/README b/board/wandboard/README
> > index e0b0b33..8bf646d 100644
> > --- a/board/wandboard/README
> > +++ b/board/wandboard/README
> > @@ -14,12 +14,12 @@ Building U-boot for Wandboard
> >
> >  To build U-Boot for the Wandboard Dual Lite version:
> >
> > -$ make wanboard_dl_config
> > +$ make WANBOARD_DL_config
> >  $ make
> >
> >  To build U-Boot for the Wandboard Solo version:
> >
> > -$ make wanboard_solo_config
> > +$ make WANBOARD_SOLO_config
> >  $ make
>
> Both "fixes" are wrong.  First, the target names are _really lower
> case.  Second, the name is wan>d<board, i. e. you still have the 'd'
> missing.  Please change into:
>
>         $ make wandboard_dl_config
> resp.
>         $ make wandboard_solo_config
>

http://git.denx.de/?p=u-boot/u-boot-imx.git;a=commitdiff;h=8c4983779ed50090b74d56498be17cde31892a64


Already fixed.
Shigeru Yoshida - June 13, 2013, 1:39 p.m.
2013/6/13 Otavio Salvador <otavio@ossystems.com.br>

>
>
> http://git.denx.de/?p=u-boot/u-boot-imx.git;a=commitdiff;h=8c4983779ed50090b74d56498be17cde31892a64
>
>
> Already fixed.
>

This patch worked my environment.
Thank you!

Patch

diff --git a/board/wandboard/README b/board/wandboard/README
index e0b0b33..8bf646d 100644
--- a/board/wandboard/README
+++ b/board/wandboard/README
@@ -14,12 +14,12 @@  Building U-boot for Wandboard

 To build U-Boot for the Wandboard Dual Lite version:

-$ make wanboard_dl_config
+$ make WANBOARD_DL_config
 $ make

 To build U-Boot for the Wandboard Solo version:

-$ make wanboard_solo_config
+$ make WANBOARD_SOLO_config
 $ make

 Flashing U-boot into the SD card