| Message ID | 1371074066-732-1-git-send-email-dsmith@vtiinstruments.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Jagannadha Sutradharudu Teki |
| Headers | show |
Hi,
Thanks for sending this.
Few comments.
1. Please use subject prefix with version number this case it should
be "PATH v3"
2. Commit header should be stand' one as all follows.
" spi: fsl_espi: "
On Thu, Jun 13, 2013 at 3:24 AM, Dale P. Smith
<dsmith@vtiinstruments.com> wrote:
>
> Signed-off-by: Dale P. Smith <dsmith@vtiinstruments.com>
> ---
> drivers/spi/fsl_espi.c | 10 ++--------
> 1 files changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/spi/fsl_espi.c b/drivers/spi/fsl_espi.c
> index 28609ee..bd9dc64 100644
> --- a/drivers/spi/fsl_espi.c
> +++ b/drivers/spi/fsl_espi.c
> @@ -287,17 +287,11 @@ int spi_xfer(struct spi_slave *slave, unsigned int bitlen, const void *data_out,
> debug("***spi_xfer:...%08x readed\n", tmpdin);
> }
> }
> - if (data_in) {
> - memcpy(data_in, buffer + 2 * cmd_len, tran_len);
> - if (*buffer == 0x0b) {
> - data_in += tran_len;
> - data_len -= tran_len;
> - *(int *)buffer += tran_len;
> - }
> - }
> spi_cs_deactivate(slave);
> }
>
> + if (data_in)
> + memcpy(data_in, buffer + rx_offset, len);
> free(buffer);
> return 0;
Have tested this recently?
Thanks,
Jagan.
Hi Jagan, Dale, On Thu, 13 Jun 2013 08:09:04 +0530, Jagan Teki <jagannadh.teki@gmail.com> wrote: > Hi, > > Thanks for sending this. > > Few comments. > 1. Please use subject prefix with version number this case it should > be "PATH v3" Plus if it is v3, then it should have patch history too. Amicalement,
On Thu, Jun 13, 2013 at 2:39 PM, Albert ARIBAUD <albert.u.boot@aribaud.net> wrote: > Hi Jagan, Dale, > > On Thu, 13 Jun 2013 08:09:04 +0530, Jagan Teki > <jagannadh.teki@gmail.com> wrote: > >> Hi, >> >> Thanks for sending this. >> >> Few comments. >> 1. Please use subject prefix with version number this case it should >> be "PATH v3" > > Plus if it is v3, then it should have patch history too. > Thanks Amicalement, Hi Dale, Please refer these 3 points for sending your v3. I am just pointing to a link for sending version patches ignore this if you know it already http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions -- Thanks, Jagan.
diff --git a/drivers/spi/fsl_espi.c b/drivers/spi/fsl_espi.c index 28609ee..bd9dc64 100644 --- a/drivers/spi/fsl_espi.c +++ b/drivers/spi/fsl_espi.c @@ -287,17 +287,11 @@ int spi_xfer(struct spi_slave *slave, unsigned int bitlen, const void *data_out, debug("***spi_xfer:...%08x readed\n", tmpdin); } } - if (data_in) { - memcpy(data_in, buffer + 2 * cmd_len, tran_len); - if (*buffer == 0x0b) { - data_in += tran_len; - data_len -= tran_len; - *(int *)buffer += tran_len; - } - } spi_cs_deactivate(slave); } + if (data_in) + memcpy(data_in, buffer + rx_offset, len); free(buffer); return 0; }
Signed-off-by: Dale P. Smith <dsmith@vtiinstruments.com> --- drivers/spi/fsl_espi.c | 10 ++-------- 1 files changed, 2 insertions(+), 8 deletions(-)