From patchwork Wed Mar 25 14:08:16 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Patrick McHardy X-Patchwork-Id: 25087 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 57F17DDD04 for ; Thu, 26 Mar 2009 01:09:13 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754865AbZCYOI1 (ORCPT ); Wed, 25 Mar 2009 10:08:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754785AbZCYOI0 (ORCPT ); Wed, 25 Mar 2009 10:08:26 -0400 Received: from stinky.trash.net ([213.144.137.162]:63715 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754865AbZCYOIZ (ORCPT ); Wed, 25 Mar 2009 10:08:25 -0400 Received: from [192.168.0.100] (unknown [78.42.204.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by stinky.trash.net (Postfix) with ESMTPSA id 07245948A2; Wed, 25 Mar 2009 15:08:22 +0100 (MET) Message-ID: <49CA3AD0.1090601@trash.net> Date: Wed, 25 Mar 2009 15:08:16 +0100 From: Patrick McHardy User-Agent: Mozilla-Thunderbird 2.0.0.19 (X11/20090103) MIME-Version: 1.0 To: Subrata Modak CC: "David S. Miller" , Sachin Sant , netdev , linux-next@vger.kernel.org, Stephen Rothwell , LKML , Adam Nielsen Subject: Re: [PATCH] Re: Next March 25: net/netfilter/xt_LED build failure. References: <20090325135759.4397.53055.sendpatchset@subratamodak.linux.ibm.com> In-Reply-To: <20090325135759.4397.53055.sendpatchset@subratamodak.linux.ibm.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Subrata Modak wrote: > The following patch will solve the build problem reported by Sachin. > But would leave the following warnings. I hope we can ignore them: > > net/netfilter/xt_LED.c: In function �led_timeout_callback�: > net/netfilter/xt_LED.c:78: warning: unused variable �ledinternal� > net/netfilter/xt_LED.c: In function �led_tg_check�: > net/netfilter/xt_LED.c:87: warning: unused variable �err� > > Signed-Off-By: Subrata Modak > --- > > --- a/linux-2.6.29/net/netfilter/xt_LED.c 2009-03-25 18:38:08.000000000 +0530 > +++ b/linux-2.6.29/net/netfilter/xt_LED.c 2009-03-25 18:26:55.000000000 +0530 > @@ -99,6 +99,7 @@ static bool led_tg_check(const struct xt > > ledinternal->netfilter_led_trigger.name = ledinfo->id; > > +#ifdef CONFIG_LEDS_TRIGGERS ... Does this patch fix it? diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig index 2562d05..2c967e4 100644 --- a/net/netfilter/Kconfig +++ b/net/netfilter/Kconfig @@ -374,7 +374,7 @@ config NETFILTER_XT_TARGET_HL config NETFILTER_XT_TARGET_LED tristate '"LED" target support' - depends on LEDS_CLASS + depends on LEDS_CLASS && LED_TRIGGERS depends on NETFILTER_ADVANCED help This option adds a `LED' target, which allows you to blink LEDs in