Patchwork SPE detection broken on Linux (bits/predefs.h: No such file or directory)

login
register
mail settings
Submitter Matthias Klose
Date June 12, 2013, 1:54 p.m.
Message ID <51B87DB1.1090400@ubuntu.com>
Download mbox | patch
Permalink /patch/250792/
State New
Headers show

Comments

Matthias Klose - June 12, 2013, 1:54 p.m.
Am 12.06.2013 13:05, schrieb Olivier Hainque:
> 
> On Jun 11, 2013, at 16:50 , David Edelsohn <dje.gcc@gmail.com> wrote:
>>> I solved this in gcc/config/rs6000/t-linux by replacing the line
>>>
>>> MULTIARCH_DIRNAME = powerpc-linux-gnuspe$(if $(findstring
>>> rs6000/e500-double.h, $(tm_file_list)),,v1)
>>>
>>> with
>>>
>>> MULTIARCH_DIRNAME = powerpc-linux-gnuspe$(if $(findstring
>>> 8548,$(with_cpu)),,v1)
>>
>> Olivier was the person who removed e500-double.h and added 8548
>> support.  I would like to hear his and Eric's comment since they seem
>> to be doing the most work on e500 at the moment.
> 
>  The suggested update is in line with this part of the
>  change we did at the time:
[...]
>  so looks correct to me. Thanks!

committed the following patch on behalf of Roland to trunk.

  Matthias
2013-06-12  Roland Stigge <stigge@antcom.de>

	* config/rs6000/t-linux (MULTIARCH_DIRNAME): Fix SPE version detection.

Patch

Index: config/rs6000/t-linux
===================================================================
--- config/rs6000/t-linux	(revision 200008)
+++ config/rs6000/t-linux	(working copy)
@@ -2,7 +2,7 @@ 
 # or soft-float.
 ifeq (,$(filter $(with_cpu),$(SOFT_FLOAT_CPUS))$(findstring soft,$(with_float)))
 ifneq (,$(findstring spe,$(target)))
-MULTIARCH_DIRNAME = powerpc-linux-gnuspe$(if $(findstring rs6000/e500-double.h, $(tm_file_list)),,v1)
+MULTIARCH_DIRNAME = powerpc-linux-gnuspe$(if $(findstring 8548,$(with_cpu)),,v1)
 else
 MULTIARCH_DIRNAME = powerpc-linux-gnu
 endif