Message ID | 1370974493-21822-4-git-send-email-sjg@chromium.org |
---|---|
State | Accepted |
Delegated to: | Tom Rini |
Headers | show
Return-Path: <u-boot-bounces@lists.denx.de> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 1947F2C0085 for <incoming@patchwork.ozlabs.org>; Wed, 12 Jun 2013 04:17:16 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 375704A0BB; Tue, 11 Jun 2013 20:17:07 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vU+MJW6fZRaq; Tue, 11 Jun 2013 20:17:07 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id BBA0C4A0BE; Tue, 11 Jun 2013 20:16:13 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id D78584A0F8 for <u-boot@lists.denx.de>; Tue, 11 Jun 2013 20:16:06 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6qqEUEgG2wYk for <u-boot@lists.denx.de>; Tue, 11 Jun 2013 20:15:51 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-qe0-f74.google.com (mail-qe0-f74.google.com [209.85.128.74]) by theia.denx.de (Postfix) with ESMTPS id 141D34A096 for <u-boot@lists.denx.de>; Tue, 11 Jun 2013 20:15:44 +0200 (CEST) Received: by mail-qe0-f74.google.com with SMTP id a11so296323qen.1 for <u-boot@lists.denx.de>; Tue, 11 Jun 2013 11:15:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=BFF68xY9qExOGMGW2sfDf8nQtLXfVi9fPTGs9/S2xIc=; b=NUfzNfWS/s+yPdSUlmTMBwppz7sxPhRWAxcSd95O66Yp/0O94DQzqFsfKUzpABs9BT f+V1HKJ3nE6Zq1ZHjfYoJ0uS1QtIxHMUweuN3rvKBZiD5zGM9YMf8rcNY5nOWJM/U35T ZRpgBEUv61ZMyXsBO79hJmm5SNIc7bnJacBEqZ9EHgvnl8n/6KzQRyT48aimEWWYtHLr GIjrAnD+GDXFKX6WZ9edgaHYJJK0NWXH89UYrp9PVc5MP8ybWz1kBb8KPKjP7768BEJ/ 1XvTKAZKVgVB7zmuRAm7jp2h4QjJF48nCry7/Uw3Z2XJ6+k70nE2a23F8Wh8qW5kMyPZ Xs3A== X-Received: by 10.236.143.101 with SMTP id k65mr8763468yhj.45.1370974543592; Tue, 11 Jun 2013 11:15:43 -0700 (PDT) Received: from corp2gmr1-1.hot.corp.google.com (corp2gmr1-1.hot.corp.google.com [172.24.189.92]) by gmr-mx.google.com with ESMTPS id 10si913338yhj.6.2013.06.11.11.15.43 for <multiple recipients> (version=TLSv1.1 cipher=AES128-SHA bits=128/128); Tue, 11 Jun 2013 11:15:43 -0700 (PDT) Received: from kaka.mtv.corp.google.com (kaka.mtv.corp.google.com [172.22.83.1]) by corp2gmr1-1.hot.corp.google.com (Postfix) with ESMTP id 6FDE831C1AE; Tue, 11 Jun 2013 11:15:43 -0700 (PDT) Received: by kaka.mtv.corp.google.com (Postfix, from userid 121222) id 20B77160855; Tue, 11 Jun 2013 11:15:43 -0700 (PDT) From: Simon Glass <sjg@chromium.org> To: U-Boot Mailing List <u-boot@lists.denx.de> Date: Tue, 11 Jun 2013 11:14:35 -0700 Message-Id: <1370974493-21822-4-git-send-email-sjg@chromium.org> X-Mailer: git-send-email 1.8.3 In-Reply-To: <1370974493-21822-1-git-send-email-sjg@chromium.org> References: <1370974493-21822-1-git-send-email-sjg@chromium.org> X-Gm-Message-State: ALoCoQnT6ZYKvUyLDIRIays/vntUB97oOVemOUnSEqG9vhkR0YmFHG71jI1JUXzFcCV27OFrFy7Tobxis7WxXM47bG37zk/VYivuGKHnKpzrih4tBxR19WFhL9L60CJ50hy4HzByL9J3egOOrM5DzcjgdABGenGeZq8Zf14kCadTwYU2rRvGJ7gA3z9mJo6HpExa4Spn7nG8 Cc: Tom Rini <trini@ti.com>, u-boot-review@google.com Subject: [U-Boot] [PATCH v2 03/21] Fix missing return in do_mem_loop() X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion <u-boot.lists.denx.de> List-Unsubscribe: <http://lists.denx.de/mailman/options/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=unsubscribe> List-Archive: <http://lists.denx.de/pipermail/u-boot> List-Post: <mailto:u-boot@lists.denx.de> List-Help: <mailto:u-boot-request@lists.denx.de?subject=help> List-Subscribe: <http://lists.denx.de/mailman/listinfo/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=subscribe> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de |
diff --git a/common/cmd_mem.c b/common/cmd_mem.c index 6df00b1..77eafa0 100644 --- a/common/cmd_mem.c +++ b/common/cmd_mem.c @@ -551,6 +551,8 @@ static int do_mem_loop(cmd_tbl_t *cmdtp, int flag, int argc, *cp++; } unmap_sysmem(buf); + + return 0; } #ifdef CONFIG_LOOPW
For some reason this does not normally cause a compiler warning, but the code seems to be incorrect. Add the missing return. Signed-off-by: Simon Glass <sjg@chromium.org> --- Changes in v2: - Add new patch to fix compiler warning in do_mem_loop() common/cmd_mem.c | 2 ++ 1 file changed, 2 insertions(+)