| Message ID | 1370882053.1933.13.camel@bwh-desktop.uk.level5networks.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
Ben Hutchings wrote: > > net_device::dev_id should not be used merely to indicate a VI index, > as it affects the way the local part of IPv6 addresses is normally > generated. > > This field was intended for use where multiple devices may share a > single assigned MAC address and need to have different IPv6 addresses. > T4 VIs each have their own MAC address. > > Signed-off-by: Ben Hutchings <bhutchings@solarflare.com> Acked-by: Dimitris Michailidis <dm@chelsio.com> > --- > Dimitris, I don't know whether my last statement ('VIs each have their > own MAC address') is actually correct. If not then the driver is quite > right to set dev_id. Ben, yes, VIs have individual MAC addresses. Thanks for doing the patch.
From: Dimitrios Michailidis <dm@chelsio.com> Date: Thu, 13 Jun 2013 06:15:43 +0000 > Ben Hutchings wrote: >> >> net_device::dev_id should not be used merely to indicate a VI index, >> as it affects the way the local part of IPv6 addresses is normally >> generated. >> >> This field was intended for use where multiple devices may share a >> single assigned MAC address and need to have different IPv6 addresses. >> T4 VIs each have their own MAC address. >> >> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com> > > Acked-by: Dimitris Michailidis <dm@chelsio.com> Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c index bff89a4..4cbb2f9 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c +++ b/drivers/net/ethernet/chelsio/cxgb4/t4_hw.c @@ -3782,7 +3782,6 @@ int t4_port_init(struct adapter *adap, int mbox, int pf, int vf) p->lport = j; p->rss_size = rss_size; memcpy(adap->port[i]->dev_addr, addr, ETH_ALEN); - adap->port[i]->dev_id = j; ret = ntohl(c.u.info.lstatus_to_modtype); p->mdio_addr = (ret & FW_PORT_CMD_MDIOCAP) ?
net_device::dev_id should not be used merely to indicate a VI index, as it affects the way the local part of IPv6 addresses is normally generated. This field was intended for use where multiple devices may share a single assigned MAC address and need to have different IPv6 addresses. T4 VIs each have their own MAC address. Signed-off-by: Ben Hutchings <bhutchings@solarflare.com> --- Dimitris, I don't know whether my last statement ('VIs each have their own MAC address') is actually correct. If not then the driver is quite right to set dev_id. Ben. drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 1 - 1 file changed, 1 deletion(-)