Patchwork powerpc/83xx: Update ranges in gianfar node to match other dts

login
register
mail settings
Submitter Anton Vorontsov
Date March 24, 2009, 2:20 p.m.
Message ID <20090324142045.GA17184@oksana.dev.rtsoft.ru>
Download mbox | patch
Permalink /patch/25014/
State Not Applicable, archived
Headers show

Comments

Anton Vorontsov - March 24, 2009, 2:20 p.m.
On Tue, Mar 24, 2009 at 08:35:45AM -0500, Kumar Gala wrote:
> The gianfar node @ 25000 was missing its ranges prop for the mdio bus
> and provided an explicit ranges property on gianfar@24000 to match
> all other .dts
> 
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---

I think this part is missing:



>  arch/powerpc/boot/dts/mpc8313erdb.dts |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/powerpc/boot/dts/mpc8313erdb.dts b/arch/powerpc/boot/dts/mpc8313erdb.dts
> index 3ebf7ec..20a0fa8 100644
> --- a/arch/powerpc/boot/dts/mpc8313erdb.dts
> +++ b/arch/powerpc/boot/dts/mpc8313erdb.dts
> @@ -180,7 +180,7 @@
>  			#address-cells = <1>;
>  			#size-cells = <1>;
>  			sleep = <&pmc 0x20000000>;
> -			ranges;
> +			ranges = <0x0 0x24000 0x1000>;
>  
>  			cell-index = <0>;
>  			device_type = "network";
> @@ -221,6 +221,7 @@
>  			model = "eTSEC";
>  			compatible = "gianfar";
>  			reg = <0x25000 0x1000>;
> +			ranges = <0x0 0x25000 0x1000>;
>  			local-mac-address = [ 00 00 00 00 00 00 ];
>  			interrupts = <34 0x8 33 0x8 32 0x8>;
>  			interrupt-parent = <&ipic>;
> -- 
> 1.5.6.6
Kumar Gala - March 24, 2009, 2:24 p.m.
On Mar 24, 2009, at 9:20 AM, Anton Vorontsov wrote:

> On Tue, Mar 24, 2009 at 08:35:45AM -0500, Kumar Gala wrote:
>> The gianfar node @ 25000 was missing its ranges prop for the mdio bus
>> and provided an explicit ranges property on gianfar@24000 to match
>> all other .dts
>>
>> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
>> ---
>
> I think this part is missing:
>
> diff --git a/arch/powerpc/boot/dts/mpc8313erdb.dts b/arch/powerpc/ 
> boot/dts/mpc8313erdb.dts
> index 3ebf7ec..98de8bf 100644
> --- a/arch/powerpc/boot/dts/mpc8313erdb.dts
> +++ b/arch/powerpc/boot/dts/mpc8313erdb.dts
> @@ -195,11 +195,11 @@
> 			fixed-link = <1 1 1000 0 0>;
> 			fsl,magic-packet;
>
> -			mdio@24520 {
> +			mdio@520 {
> 				#address-cells = <1>;
> 				#size-cells = <0>;
> 				compatible = "fsl,gianfar-mdio";
> -				reg = <0x24520 0x20>;
> +				reg = <0x520 0x20>;
> 				phy4: ethernet-phy@4 {
> 					interrupt-parent = <&ipic>;
> 					interrupts = <20 0x8>;
> @@ -229,11 +229,11 @@
> 			sleep = <&pmc 0x10000000>;
> 			fsl,magic-packet;
>
> -			mdio@25520 {
> +			mdio@520 {
> 				#address-cells = <1>;
> 				#size-cells = <0>;
> 				compatible = "fsl,gianfar-tbi";
> -				reg = <0x25520 0x20>;
> +				reg = <0x520 0x20>;
>
> 				tbi1: tbi-phy@11 {
> 					reg = <0x11>;
>>

yep, sending a new version

- k

Patch

diff --git a/arch/powerpc/boot/dts/mpc8313erdb.dts b/arch/powerpc/boot/dts/mpc8313erdb.dts
index 3ebf7ec..98de8bf 100644
--- a/arch/powerpc/boot/dts/mpc8313erdb.dts
+++ b/arch/powerpc/boot/dts/mpc8313erdb.dts
@@ -195,11 +195,11 @@ 
 			fixed-link = <1 1 1000 0 0>;
 			fsl,magic-packet;
 
-			mdio@24520 {
+			mdio@520 {
 				#address-cells = <1>;
 				#size-cells = <0>;
 				compatible = "fsl,gianfar-mdio";
-				reg = <0x24520 0x20>;
+				reg = <0x520 0x20>;
 				phy4: ethernet-phy@4 {
 					interrupt-parent = <&ipic>;
 					interrupts = <20 0x8>;
@@ -229,11 +229,11 @@ 
 			sleep = <&pmc 0x10000000>;
 			fsl,magic-packet;
 
-			mdio@25520 {
+			mdio@520 {
 				#address-cells = <1>;
 				#size-cells = <0>;
 				compatible = "fsl,gianfar-tbi";
-				reg = <0x25520 0x20>;
+				reg = <0x520 0x20>;
 
 				tbi1: tbi-phy@11 {
 					reg = <0x11>;