[net-next] net: ping_check_bind_addr() etc. can be static

net/ipv4/ping.c:286:5: sparse: symbol 'ping_check_bind_addr' was not declared. Should it be static?
net/ipv4/ping.c:355:6: sparse: symbol 'ping_set_saddr' was not declared. Should it be static?
net/ipv4/ping.c:370:6: sparse: symbol 'ping_clear_saddr' was not declared. Should it be static?

net/ipv6/ping.c:60:5: sparse: symbol 'dummy_ipv6_recv_error' was not declared. Should it be static?
net/ipv6/ping.c:64:5: sparse: symbol 'dummy_ip6_datagram_recv_ctl' was not declared. Should it be static?
net/ipv6/ping.c:69:5: sparse: symbol 'dummy_icmpv6_err_convert' was not declared. Should it be static?
net/ipv6/ping.c:73:6: sparse: symbol 'dummy_ipv6_icmp_error' was not declared. Should it be static?
net/ipv6/ping.c:75:5: sparse: symbol 'dummy_ipv6_chk_addr' was not declared. Should it be static?

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 net/ipv4/ping.c |    6 +++---
 net/ipv6/ping.c |   10 +++++-----
 2 files changed, 8 insertions(+), 8 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

From: Fengguang Wu <fengguang.wu@intel.com>
Date: Sun, 9 Jun 2013 20:24:26 +0800

>  /* Checks the bind address and possibly modifies sk->sk_bound_dev_if. */
> -int ping_check_bind_addr(struct sock *sk, struct inet_sock *isk,
> +static int ping_check_bind_addr(struct sock *sk, struct inet_sock *isk,
>  			 struct sockaddr *uaddr, int addr_len) {

In all of these cases, you have to fix the indentation of all of the
argument lines when the change the location of the openning
parenthesis of the first line of the function definition.

That's because in the networking we indent function declarations
in the following way:

int foo(int arg1, int arg2, int arg3,
	int arg4, int arg5)

Specifically, the arguments that are declared on the second and
subsequent lines must start at the first column after the openning
parenthesis.  This must be done using the appropriate number of
TAB and space characters necessary to achieve that exact column.

Please fix this up and combine your two patches into one.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

On Wed, Jun 12, 2013 at 01:17:52AM -0700, David Miller wrote:
> From: Fengguang Wu <fengguang.wu@intel.com>
> Date: Sun, 9 Jun 2013 20:24:26 +0800
> 
> >  /* Checks the bind address and possibly modifies sk->sk_bound_dev_if. */
> > -int ping_check_bind_addr(struct sock *sk, struct inet_sock *isk,
> > +static int ping_check_bind_addr(struct sock *sk, struct inet_sock *isk,
> >  			 struct sockaddr *uaddr, int addr_len) {
> 
> In all of these cases, you have to fix the indentation of all of the
> argument lines when the change the location of the openning
> parenthesis of the first line of the function definition.
> 
> That's because in the networking we indent function declarations
> in the following way:
> 
> int foo(int arg1, int arg2, int arg3,
> 	int arg4, int arg5)
> 
> Specifically, the arguments that are declared on the second and
> subsequent lines must start at the first column after the openning
> parenthesis.  This must be done using the appropriate number of
> TAB and space characters necessary to achieve that exact column.
> 
> Please fix this up and combine your two patches into one.

OK I'll rework the patch, thank you for the kind tips!

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html