From patchwork Fri Jun 7 21:08:08 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rajendra Dendukuri X-Patchwork-Id: 249855 X-Patchwork-Delegate: patrickdepinguin+buildroot@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from silver.osuosl.org (silver.osuosl.org [140.211.166.136]) by ozlabs.org (Postfix) with ESMTP id 3E76C2C00A2 for ; Sat, 8 Jun 2013 07:08:33 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 093F931909; Fri, 7 Jun 2013 21:08:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CbL6BBVVh2vO; Fri, 7 Jun 2013 21:08:30 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 698FC3190E; Fri, 7 Jun 2013 21:08:30 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 9326E8F7A4 for ; Fri, 7 Jun 2013 21:08:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 8AEF18E828 for ; Fri, 7 Jun 2013 21:08:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7Fezl44jVhMd for ; Fri, 7 Jun 2013 21:08:23 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mms3.broadcom.com (mms3.broadcom.com [216.31.210.19]) by whitealder.osuosl.org (Postfix) with ESMTP id 8C2CF8E86B for ; Fri, 7 Jun 2013 21:08:19 +0000 (UTC) Received: from [10.9.208.53] by mms3.broadcom.com with ESMTP (Broadcom SMTP Relay (Email Firewall v6.5)); Fri, 07 Jun 2013 13:59:13 -0700 X-Server-Uuid: B86B6450-0931-4310-942E-F00ED04CA7AF Received: from SJEXCHCAS06.corp.ad.broadcom.com (10.16.203.14) by IRVEXCHCAS06.corp.ad.broadcom.com (10.9.208.53) with Microsoft SMTP Server (TLS) id 14.1.438.0; Fri, 7 Jun 2013 14:08:09 -0700 Received: from SJEXCHMB09.corp.ad.broadcom.com ( [fe80::3da7:665e:cc78:181f]) by SJEXCHCAS06.corp.ad.broadcom.com ( [::1]) with mapi id 14.01.0438.000; Fri, 7 Jun 2013 14:08:09 -0700 From: "Rajendra Dendukuri" To: "Thomas Petazzoni" Thread-Topic: [Buildroot] UCLIBC_EXTRA_CFLAGS in uClibc overridden while using buildroot Thread-Index: Ac5i6/mjsSCztBaZTDSBjk0w2FIQDQAs9d8AAAjDZgA= Date: Fri, 7 Jun 2013 21:08:08 +0000 Message-ID: <43F7AEDD312F9E499A1A4E3608E505ED2ABF14F2@SJEXCHMB09.corp.ad.broadcom.com> References: <43F7AEDD312F9E499A1A4E3608E505ED2ABF12D3@SJEXCHMB09.corp.ad.broadcom.com> <20130607115530.7132b7b1@skate> In-Reply-To: <20130607115530.7132b7b1@skate> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.16.203.100] MIME-Version: 1.0 X-WSS-ID: 7DAC962B2L829630733-01-01 Cc: "buildroot@busybox.net" Subject: Re: [Buildroot] UCLIBC_EXTRA_CFLAGS in uClibc overridden while using buildroot X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net Thanks for the inputs. The said patch works. Can we get this into release buildroot source tree. /rajen -----Original Message----- From: Thomas Petazzoni [mailto:thomas.petazzoni@free-electrons.com] Sent: Friday, June 07, 2013 5:55 AM To: Rajendra Dendukuri Cc: buildroot@busybox.net Subject: Re: [Buildroot] UCLIBC_EXTRA_CFLAGS in uClibc overridden while using buildroot Dear Rajendra Dendukuri, On Thu, 6 Jun 2013 19:33:30 +0000, Rajendra Dendukuri wrote: > I am using buildroot-2012.11 version to build a uClibc toolchain for ARMv7a. I find that uClibc/Rules.mak file defaults to -Os. However I wish to include "-fno-omit-frame-pointer" even when -Os optimization is used. I cannot find a hook in buildroot or uClibc where this can be done. I tried setting the value of UCLIBC_EXTRA_CFGLAGS in the uClibc config file. However that is not being considered. Instead the values passed by buildroot in "toolchain/uClibc/uclibc.mk" are being used. > > This seems to be a very stiff limitation while using uClibc with buildroot. Any suggestions on how we can overcome this. Can you try the following patch, and add -fno-omit-frame-pointer to BR2_TARGET_OPTIMIZATION ? diff --git a/toolchain/uClibc/uclibc.mk b/toolchain/uClibc/uclibc.mk index d4f1d4c..8ecb712 100644 --- a/toolchain/uClibc/uclibc.mk +++ b/toolchain/uClibc/uclibc.mk @@ -392,7 +392,7 @@ $(UCLIBC_DIR)/.config: $(UCLIBC_DIR)/.oldconfig DEVEL_PREFIX=/usr/ \ RUNTIME_PREFIX=$(TOOLCHAIN_DIR)/uClibc_dev/ \ CROSS_COMPILE="$(TARGET_CROSS)" \ - UCLIBC_EXTRA_CFLAGS="$(TARGET_ABI)" \ + UCLIBC_EXTRA_CFLAGS="$(TARGET_CFLAGS)" \ HOSTCC="$(HOSTCC)" \ oldconfig touch $@ @@ -423,7 +423,7 @@ $(UCLIBC_DIR)/.configured: $(LINUX_HEADERS_DIR)/.configured $(UCLIBC_DIR)/.confi DEVEL_PREFIX=/usr/ \ RUNTIME_PREFIX=$(TOOLCHAIN_DIR)/uClibc_dev/ \ CROSS_COMPILE="$(TARGET_CROSS)" \ - UCLIBC_EXTRA_CFLAGS="$(TARGET_ABI)" \ + UCLIBC_EXTRA_CFLAGS="$(TARGET_CFLAGS)" \ HOSTCC="$(HOSTCC)" headers \ lib/crt1.o lib/crti.o lib/crtn.o \ install_headers @@ -446,7 +446,7 @@ $(UCLIBC_DIR)/lib/libc.a: $(UCLIBC_DIR)/.configured $(gcc_intermediate) $(LIBFLO DEVEL_PREFIX=/ \ RUNTIME_PREFIX=/ \ CROSS_COMPILE="$(TARGET_CROSS)" \ - UCLIBC_EXTRA_CFLAGS="$(TARGET_ABI)" \ + UCLIBC_EXTRA_CFLAGS="$(TARGET_CFLAGS)" \ HOSTCC="$(HOSTCC)" \ all touch -c $@ @@ -458,7 +458,7 @@ uclibc-menuconfig: dirs $(UCLIBC_DIR)/.config DEVEL_PREFIX=/usr/ \ RUNTIME_PREFIX=$(TOOLCHAIN_DIR)/uClibc_dev/ \ CROSS_COMPILE="$(TARGET_CROSS)" \ - UCLIBC_EXTRA_CFLAGS="$(TARGET_ABI)" \ + UCLIBC_EXTRA_CFLAGS="$(TARGET_CFLAGS)" \ HOSTCC="$(HOSTCC)" \ menuconfig && \ touch -c $(UCLIBC_DIR)/.config @@ -472,7 +472,7 @@ $(STAGING_DIR)/usr/lib/libc.a: $(UCLIBC_DIR)/lib/libc.a DEVEL_PREFIX=/usr/ \ RUNTIME_PREFIX=/ \ CROSS_COMPILE="$(TARGET_CROSS)" \ - UCLIBC_EXTRA_CFLAGS="$(TARGET_ABI)" \ + UCLIBC_EXTRA_CFLAGS="$(TARGET_CFLAGS)" \ install_runtime install_dev # Install the kernel headers to the staging dir if necessary if [ ! -f $(STAGING_DIR)/usr/include/linux/version.h ]; then \ @@ -503,7 +503,7 @@ $(TARGET_DIR)/lib/libc.so.0: $(STAGING_DIR)/usr/lib/libc.a DEVEL_PREFIX=/usr/ \ RUNTIME_PREFIX=/ \ CROSS_COMPILE="$(TARGET_CROSS)" \ - UCLIBC_EXTRA_CFLAGS="$(TARGET_ABI)" \ + UCLIBC_EXTRA_CFLAGS="$(TARGET_CFLAGS)" \ install_runtime touch -c $@